without MD, this file becomes a good deal simpler, and a lot of the constants could/should be moved out to the one place where they're used. Some constants could be combined. See https://codereview.chromium.org/2444923003/
also clean up ash/common/ash_layout_constants.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90509e4e9bf1be47bd971792af7ab764f2b29489 commit 90509e4e9bf1be47bd971792af7ab764f2b29489 Author: estade <estade@chromium.org> Date: Thu Dec 01 02:23:09 2016 Top Chrome MD cleanup - get rid of most of GetLayoutInsets. BUG= 660445 Review-Url: https://codereview.chromium.org/2523783002 Cr-Commit-Position: refs/heads/master@{#435529} [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/layout_constants.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/layout_constants.h [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/toolbar/app_menu_button.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/90509e4e9bf1be47bd971792af7ab764f2b29489/chrome/browser/ui/views/toolbar/toolbar_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c4e98197eefddf7f25cc42e6142c80a5e500323 commit 2c4e98197eefddf7f25cc42e6142c80a5e500323 Author: estade <estade@chromium.org> Date: Tue Dec 13 03:08:36 2016 Last round of cleaning up MD layout constants. BUG= 660445 Review-Url: https://codereview.chromium.org/2555623002 Cr-Commit-Position: refs/heads/master@{#438014} [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/layout_constants.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/layout_constants.h [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/frame/browser_non_client_frame_view.h [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/frame/browser_view_layout.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/frame/browser_view_unittest.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/location_bar/background_with_1_px_border.h [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/location_bar/content_setting_image_view.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/location_bar/keyword_hint_view.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/tabs/tab.h [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/toolbar/app_menu_button.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/toolbar/toolbar_button.h [modify] https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323/chrome/browser/ui/views/toolbar/toolbar_view.cc
Comment 1 by est...@chromium.org
, Nov 2 2016