New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660434 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Oct 2016
Cc:
calamity@chromium.org
dbeam@chromium.org
█ tsergeant@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 641663



Sign in to add a comment

Bogus 'search-changed' event fired from CrSearchFieldBehavior on startup.

Project Member Reported by dpa...@chromium.org, Oct 28 2016 
cr_search_field_behavior is firing an accidental 'search-changed' event on startup even though the user did not issue any search (because of how Polymer property observers work). Working around this makes client code cryptic (and puzzles reviewers).

I have a fix and a test at https://codereview.chromium.org/2458113003.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6799603e6ec837f72dee0443f54de1e857457749

commit 6799603e6ec837f72dee0443f54de1e857457749
Author: dpapad <dpapad@chromium.org>
Date: Fri Oct 28 22:20:07 2016

Prevent bogus 'search-changed' event firing from cr_search_field_behavior.js.

BUG= 660434 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2458113003
Cr-Commit-Position: refs/heads/master@{#428518}

[modify] https://crrev.com/6799603e6ec837f72dee0443f54de1e857457749/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
[modify] https://crrev.com/6799603e6ec837f72dee0443f54de1e857457749/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

Comment 2 by dpa...@chromium.org, Oct 28 2016

Status: Fixed (was: Started)
►

Sign in to add a comment