OIB is missing an offline icon when shown for offline page. |
|||||||
Issue descriptionVersion: 56.0.2900.3, 55.0.2883.28 OS: Andorid What steps will reproduce the problem? (1) Navigate to a page (2) Click the download button (3) Open the downloaded page (from snackbar or downloads home) (4) Open OIB (clicking on the offline icon or verbose status in the omnibox) (5) notice missing icon What is the expected output? Icon should be either visible (or completely removed, which is a reasonable alternative given issue 656804 ) What do you see instead? Blank placeholder for the offline icon. Tal, Dmitry, Should this be blocking M55? (I think, yes, but wanted you to support or punt) What is the best solution? Remove the icon, given we plan to do it in M56 already and based on above we want to merge something. How hard is the fix? Pretty simple. I have the removal done for M56 and it is small change in 2 files.
,
Oct 28 2016
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4e61e9950635faed2b7713efa2b7e87e3a3b387 commit f4e61e9950635faed2b7713efa2b7e87e3a3b387 Author: fgorski <fgorski@chromium.org> Date: Fri Oct 28 21:59:53 2016 [Offline pages] Removing the offline icon from OIB Simply removing the icon placeholder (the icon does not display properly right now). BUG= 660426 Review-Url: https://codereview.chromium.org/2463443002 Cr-Commit-Position: refs/heads/master@{#428508} [modify] https://crrev.com/f4e61e9950635faed2b7713efa2b7e87e3a3b387/chrome/android/java/res/layout/website_settings.xml [modify] https://crrev.com/f4e61e9950635faed2b7713efa2b7e87e3a3b387/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
,
Oct 31 2016
Requesting merge as this UX problem affects M55 (Beta and stable)
,
Oct 31 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ab320592ea42dd65212b94d62eca40543929a21 commit 4ab320592ea42dd65212b94d62eca40543929a21 Author: Filip Gorski <fgorski@chromium.org> Date: Mon Oct 31 16:37:42 2016 [Offline pages] Removing the offline icon from OIB Simply removing the icon placeholder (the icon does not display properly right now). BUG= 660426 Review-Url: https://codereview.chromium.org/2463443002 Cr-Commit-Position: refs/heads/master@{#428508} (cherry picked from commit f4e61e9950635faed2b7713efa2b7e87e3a3b387) Review URL: https://codereview.chromium.org/2467523002 . Cr-Commit-Position: refs/branch-heads/2883@{#383} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/4ab320592ea42dd65212b94d62eca40543929a21/chrome/android/java/res/layout/website_settings.xml [modify] https://crrev.com/4ab320592ea42dd65212b94d62eca40543929a21/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
,
Oct 31 2016
,
Nov 2 2016
Offline icon from OIB is removed Issue is fixed on latest M56 Dev and M55 Beta builds. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by fgor...@chromium.org
, Oct 28 2016602 KB
602 KB View Download