Issue metadata
Sign in to add a comment
|
ChromeVox doesn't correctly handle password field on solo user pod (part 2) |
||||||||||||||||||||||||
Issue descriptionVersion: 56.0.2902.0 There are two new problems with ChromeVox on the user pod login page (the old ones in Issue 536142 have been resolved). Problem One: At login page with a single user pod, with CV on, press TAB repeatedly. When the password field is highlighted and read, the textbox doesn't receive input focus. If I TAB / SHIFT+TAB onto the options menu and back, it gets focus. Similarly, if I SHIFT+TAB / TAB onto the Status Tray and back, it also gets focus. Also, if CV is off, this works fine. It's only when CV is on and I get to the password field after two consecutive TABs that focus isn't put on the text field. Problem Two: If I use CV+RIGHT to navigate through page elements, CV selects and reads "Password" three times, but never puts input focus on the edit box. If I use CV+LEFT, CV navigation gets stuck on the password field and can't go back any further; it still doesn't set input focus correctly. The HTML for the password edit box is here: https://cs.chromium.org/chromium/src/ui/login/account_picker/user_pod_template.html?q=password-entry-container&sq=package:chromium&l=48&dr=C
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20d6d96d1e472287cb4270b1d6c8b48973994fcd commit 20d6d96d1e472287cb4270b1d6c8b48973994fcd Author: dtseng <dtseng@chromium.org> Date: Fri Nov 04 19:31:18 2016 Fix reset and focus issues in OOBE - if an extension is toggled off then on, and re-requests the desktop automation tree, it might receive tree data for a child tree before the child tree's accessibility data is reset via chrome.automation.enableFrame. This results in the client extension tree having an embeddedObject node with one child with role unknown. Fix this by always resetting a child tree root that has unknown role - work around webview focus issues by explicitly always checking the ancestors we've crossed into and always focusing first embeddedObject nodes. This should be removed once webview handles propagating upwards focus from descendants correctly. BUG= 660390 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2470413005 Cr-Commit-Position: refs/heads/master@{#429978} [modify] https://crrev.com/20d6d96d1e472287cb4270b1d6c8b48973994fcd/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js [modify] https://crrev.com/20d6d96d1e472287cb4270b1d6c8b48973994fcd/chrome/renderer/resources/extensions/automation_custom_bindings.js
,
Nov 4 2016
,
Nov 15 2016
I can still see issues as explained in #0 on 56.0.2919.0 build
,
Nov 15 2016
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d0aa6a69b15dadb70ecbff3428e55589966bbbc commit 3d0aa6a69b15dadb70ecbff3428e55589966bbbc Author: dtseng <dtseng@chromium.org> Date: Thu Nov 17 01:41:05 2016 Try focusing embeddedObject first unconditionally We attempt, on each navigation, to focus an unfocused embeddedObject for which we are entering (i.e. the embeddedObject is an ancestor). During this process, we might have exited early if we encountered a focused range. Ensure we always check for embeddedObject's to focus. TEST=navigate in OOBE sign in screen via tab/Search+left/right. Ensure we're getting focus inside of the webview e.g. type into the text field, navigate outside to the shutdown button, navigate back into the webview, type more into the email text field and verify stuff works. BUG= 660390 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2509093002 Cr-Commit-Position: refs/heads/master@{#432684} [modify] https://crrev.com/3d0aa6a69b15dadb70ecbff3428e55589966bbbc/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
,
Nov 17 2016
Fixed as much as we can for now. These are all secondary symtoms of webview's poor programmatic focus practices (e.g. setting focus to things inside the webview doesn't actualy cause the webview to get focus itself).
,
Mar 4 2017
,
Apr 14 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtseng@chromium.org
, Nov 3 2016