New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660389 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

VDA unittest DCHECK failed: 1u == buffers[i].service_texture_ids().size() (1 vs. 0)

Project Member Reported by wuchengli@chromium.org, Oct 28 2016

Issue description

Version: sChrome HEAD=
OS: Chrome OS elm 8927.0.0 with self-built chrome (HEAD=19b1919333fad7b399a0455dd970013a90d4302b)

What steps will reproduce the problem?
(1) Set the following in args.gn.
is_component_build = false
is_debug = true
is_official_build = false

(2) Build VDA unittest
ninja -C out_${SDK_BOARD}/Debug -j2000 video_decode_accelerator_unittest

(3) Run VDA unittest on the device.
./video_decode_accelerator_unittest --test_video_data='test-25fps.h264:320:240:250:258:35:150:1' --gtest_filter=DecodeVariations/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 --v=0

What do you see instead?
The test crashed. Reverting d3088b3826b4122fc534096da1f06b9383e9bdd2 (Use clearer names for the PictureBuffer texture id members) fixed it. It looks like several |texture_ids| were incorrectly replaced with |service_texture_ids|.


[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
libEGL warning: DRI2: failed to open vgem (search paths /usr/lib/dri)
[----------] 1 test from DecodeVariations/VideoDecodeAcceleratorParamTest
[ RUN      ] DecodeVariations/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
[1028/232807:ERROR:gbm_device.cc(28)] Unable to initialize GBM for /sys/devices/soc/13000000.mfgsys-gpu/drm/card1: Invalid argument
[1028/232807:FATAL:v4l2_video_decode_accelerator.cc(387)] Check failed: 1u == buffers[i].service_texture_ids().size() (1 vs. 0)
#0 0x0000f5e2d5be base::debug::StackTrace::StackTrace()
#1 0x0000f5d5daaa logging::LogMessage::~LogMessage()
#2 0x0000f5d023d2 media::V4L2VideoDecodeAccelerator::AssignPictureBuffersTask()
#3 0x0000f5bf850e _ZN4base8internal13FunctorTraitsIMN2ui9DrmThreadEFvRKNS_8CallbackIFvRKSt6vectorINS2_22DisplaySnapshot_ParamsESaIS6_EEELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEEvE6InvokeIPS3_JSG_EEEvSI_OT_DpOT0_
#4 0x0000f5bf735c _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN2ui9DrmThreadEFvRKNS_8CallbackIFvRKSt6vectorINS4_22DisplaySnapshot_ParamsESaIS8_EEELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEEJPS5_SI_EEEvOT_DpOT0_
#5 0x0000f5d1cf58 _ZN4base8internal7InvokerINS0_9BindStateIMN5media26V4L2VideoDecodeAcceleratorEFvRKSt6vectorINS3_13PictureBufferESaIS6_EEEJNS0_17UnretainedWrapperIS4_EES8_EEEFvvEE7RunImplIRKSC_RKSt5tupleIJSE_S8_EEJLj0ELj1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#6 0x0000f5d1b912 _ZN4base8internal7InvokerINS0_9BindStateIMN5media26V4L2VideoDecodeAcceleratorEFvRKSt6vectorINS3_13PictureBufferESaIS6_EEEJNS0_17UnretainedWrapperIS4_EES8_EEEFvvEE3RunEPNS0_13BindStateBaseE
#7 0x0000f5ddce10 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv
#8 0x0000f5e2df20 base::debug::TaskAnnotator::RunTask()
#9 0x0000f5d649ca base::MessageLoop::RunTask()
#10 0x0000f5d64afa base::MessageLoop::DeferOrRunPendingTask()
#11 0x0000f5d64f12 base::MessageLoop::DoWork()
#12 0x0000f5d6ca3e base::MessagePumpDefault::Run()
#13 0x0000f5d64686 base::MessageLoop::RunHandler()
#14 0x0000f5da0c82 base::RunLoop::Run()
#15 0x0000f5dd56f4 base::Thread::Run()
#16 0x0000f5dd5d12 base::Thread::ThreadMain()
#17 0x0000f5dc7116 base::(anonymous namespace)::ThreadFunc()

Aborted (core dumped)

 

Comment 1 by w...@chromium.org, Oct 28 2016

I missed the test VDA client. Can one of you please patch this in and try it? http://crrev.com/2461033002. I don't have a chromeos build.
I tried 2461033002 and the test passed.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83ae56bab030686ec47692edf2243dfcd680e7a7

commit 83ae56bab030686ec47692edf2243dfcd680e7a7
Author: watk <watk@chromium.org>
Date: Sat Oct 29 09:05:04 2016

Fix the VDA unittest to pass texture ids in the correct order

A recent change cleaned up the naming and ordering of the client and
service texture ids in PictureBuffer and the VDA layers, but the test
wasn't updated. Now the test VDA client passes the texture ids as
service ids, because that's what they are.

BUG= 660389 

Review-Url: https://codereview.chromium.org/2461033002
Cr-Commit-Position: refs/heads/master@{#428610}

[modify] https://crrev.com/83ae56bab030686ec47692edf2243dfcd680e7a7/media/gpu/video_decode_accelerator_unittest.cc

Status: Fixed (was: Assigned)

Comment 5 by ka...@chromium.org, Jan 26 2017

Status: Verified (was: Fixed)
Verified

Sign in to add a comment