Issue metadata
Sign in to add a comment
|
Enter in omnibox to reload restores previous scroll position
Reported by
michaela...@gmail.com,
Oct 28 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36 Steps to reproduce the problem: 1. Open a webpage 2. Scroll down a little 3. Focus on address bar and hit Enter What is the expected behavior? The page should reload and scroll to the top as if an address were being entered manually (not hitting refresh). What went wrong? It appears that if the address has not changed before hitting Enter, Chrome now seems to treat this as an F5 refresh, which takes me to my previous scroll position. Did this work before? Yes 53.* Chrome version: 54.0.2840.71 m Channel: stable OS Version: 7 Flash Version: I think this may be somewhat of an oversight, and cannot find a reason as to why it would be by-design. If it is by design, is there a flag that can reverse the behaviour? (I cannot find such flag.) If there isn't a flag, can one be added?
,
Oct 28 2016
Confirmed that this is a behavior change, though I'm not as convinced the new behavior is wrong. But it's definitely true that in e.g. Chrome 52, F5 restored your scroll position and enter in the omnibox didn't. Retriaging as a navigation stack issue; the omnibox code here hasn't changed.
,
Oct 28 2016
Hmm. Blink already interprets "enter in the omnibox" as a reload, leading to some complexity in the code that we're hoping to remove (issue 536102). The strange thing is, that work hasn't landed-- shess@ has a CL in progress at https://codereview.chromium.org/2381503003/. Given the timing, I suppose it's possible that this could be caused by the new navigation path we enabled in M54, but I'm not sure how at first glance. Maybe a bisect would help confirm. I'm guessing this is a question of whether the PageState is sent on the navigation or not, and I'm not sure what would cause it to be sent. We should probably take a closer look to understand why it's happening and whether to consider it a bug. (I'm guessing that we will want to fix it, since it's a bit odd from the user's perspective even if Blink treats it as a "reload.")
,
Oct 29 2016
Thank you for the update. If this is treated as a reload, are resources refreshed at all? My concern is with regards to data usage on a page reload.
,
Oct 31 2016
Bisect info: ============ Good: 54.0.2840.18 Bad: 54.0.2840.21 Omahaproxy UI CL: https://chromium.googlesource.com/chromium/src/+log/54.0.2840.18..54.0.2840.21?pretty=fuller&n=10000 From the above CL suspecting the below: Review URL: https://codereview.chromium.org/2326983002 . toyoshim@ : Could you please take a look into this if its related to your change.
,
Oct 31 2016
Its too late for M54, since the issue already exist in M53, please target to get a fix before M55 hits Stable.
,
Oct 31 2016
Interesting! r416855 intentionally restored this state to handle the F5 / reload case. toyoshim@, did you intend for that CL to affect the enter-in-address bar case as well? I'm wondering if it's worth making an exception for that (and if issue 536102 should also take that into account).
,
Oct 31 2016
Wrong Scott.
,
Oct 31 2016
Comment 8: Oops! Sorry about that. I did mean you in comment 3. :)
,
Nov 1 2016
toyoshim@, could you please reply to comment #7.
,
Nov 7 2016
**** Bulk edit - please ignore if not applicable **** A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you! Also due to Thanksgiving holidays in US, please make sure all fixes are ready and merged to M55 latest by 5:00 PM PT Friday, 11/18/16.
,
Nov 7 2016
>#7 Yes, this is intentional change. I'm removing reload variations step by step, and eventually Chrome will have only two variations of reloads, main resource only reload and full reload. "Enter in omnibox for the same URL" is classified into the main resource only reload. That forces to revalidate main resource, and restore user states as a reload button does. HTML spec does not have a clear definition about the same page navigation, and I discuss it in parallel.
,
Nov 7 2016
Also answer for the original report is here: > If it is by design, is there a flag that can reverse the behaviour? (I cannot find such flag.) If there isn't a flag, can one be added? Actually, we have a flag that can revert this change, but it also reverts new faster reload implementation. And unfortunately, we will remove this flag soon. Now browsers have so many reload variants, and no one understand how different each reload is. This makes implementation complicated and makes it hard to maintain. This is the reason why I'm merging reload variants that have minor differences like this. So, I don't have a plan to keep current flag, or adding another flag.
,
Nov 7 2016
#4, michaelarockett@ > If this is treated as a reload, are resources refreshed at all? Only main resource is revalidated. This hasn't been changed for a long time. This is one thing that differentiates the same page navigation from a normal navigation. Also, it does not add a new navigation entry to the history. That's another difference. So, the same page navigation has behaved as a kind of light reload for a long time. #6, ligimole@ > since the issue already exist in M53 Is this true? New reload is managed via field study flag, and it was enabled only for 54.0.2840.27 and later versions on Beta, and all 54.* on Stable. The behavior change in this report is bound to the same flag, and I believe this should not happen on m53 unless you explicitly enable it. But it's also true that this behavior has been in the current Stable for weeks, and we haven't seen any strong push back until now.
,
Nov 7 2016
Sorry for my out-of-order replies, but I'd conclude this as 'WontFix' if there is no strong reason to revert.
,
Nov 7 2016
Reply to comment #14. > since the issue already exist in M53 Is this true? Sorry for the confusion , this is regression in M54.
,
Nov 8 2016
#16, thanks. So, now I'd close this bug as WontFix. If someone can not agree, please feel free to reopen this, or file another bug with CC:toyoshim@. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Oct 28 2016