New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660386 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Add integration tests for favicons

Project Member Reported by stkhapugin@chromium.org, Oct 28 2016

Issue description

To prevent https://bugs.chromium.org/p/chromium/issues/detail?id=658080 in the future, we need some tests that check that:

1. favicon appear at all
2. favicons appear specifically after scrolling

Since the issue was caused by iOS, our unit tests were useless - it's not us who broke the API contracts. Thus, we need integration tests. 
 
Labels: -Pri-3 Pri-2
Cc: stkhapugin@chromium.org
Owner: martiw@chromium.org

Comment 3 by martiw@chromium.org, Feb 18 2018

Owner: ----
Status: Available (was: Assigned)
Switched team and releasing this bug.
Owner: thegreenfrog@chromium.org
Status: Assigned (was: Available)
thegreenfrog@ is this a duplicate from the bug we created not long ago?
I created a bug for unittests for faviconloader, which is now used for all collections UI. I guess we can keep these separate, but they both exemplify the lack of tests for favicons.

Sign in to add a comment