Support for splitting traffic between equilvalent trybots in CQ |
|||||||||||||||
Issue description
As part of the transition off of buildbot we would like to be able to declare that two builders are equivalent and to accept CLs with passing results from either. Additionally, we would like to be able to whitelist users to favor one builder over the other, and to be able to split traffic by specifying percentages to divert to each builder.
The way configs are currently structured are in a hierarchy of bucket > builder, which makes this a little difficult since we want to split between builders in different buckets.
I was hoping we could have something like:
message Builder {
string name;
string bucket_name;
float experiment_percentage;
string experiment_whitelist;
}
message EquivalentBuilderGroup {
repeated Builder builders;
}
Then a config would look something like:
verifiers {
reviewer_lgtm {
committer_list: "project-infra-committers"
}
tree_status {
tree_status_url: "https://infra-status.appspot.com"
}
try_job {
# Normal builders list behaves the same.
builders {
name: "Infra Presubmit",
bucket_name: "tryserver.chromium.infra"
}
# Builder groups split traffic and must add to 100%.
equivalent_builder_group {
builder {
name: "Infra Linux Trusty 64 Tester"
bucket_name: "tryserver.chromium.infra"
experiment_percentage: 90
}
builder {
name: "Infra Linux Trusty 64 Tester"
bucket_name: "luci.infra.try"
experiment_percentage: 10
experiment_whitelist: "project-infra-luci-beta-users"
}
}
builders {
name: "Infra Win Tester"
bucket_name: "tryserver.chromium.infra"
}
}
sign_cla {}
}
Thoughts? Alternative approaches?
,
Oct 28 2016
Maybe my proposal is more complex than it needs to be, but both phajdan and tandrii seemed to think the functionality would be doable (and reusable in the future, at least the beta whitelisting) and on the order of a week or two of work. I don't consider beta whitelist nice to have but perhaps the traffic splitting. Getting volunteers to test the new system and give feedback that we can incorporate is a much friendlier launch approach than a forced rollout. Agree?
,
Oct 28 2016
yes, it is friendlier to (make a luci builder non-experimental and make it equivalent, with percentages and beta testers) than (make a luci builder non-experimental and remove old builder). Probably chromium folks would require that.
To minimize changes to cq.proto, I propose to add
message EquivalentBuilder {
// bucket of the equivalent "main" builder. Required.
string bucket
// name of the equivalent "main" builder. Required.
string builder
// how much builds should be sent to this builder and not the "main" one.
// if not specified, cq should schedule on this builder with the same
// probability as the main one
int32 percentage
// if not empty, limit the builder to CL owners in this group
string whitelist
}
message Builder {
// existing fields
EquivalentBuilder equivalent_to;
}
i think it will satisfy all three aspects of this request:
1) be able to declare a beta builder as equivalent to another one
2) be able to specify percentage of builds to be scheduled to the beta builder
3) be able to limit exposure of the beta builder to certain users
constraint: for all builders Bs equivalent to builder A, sum of percentages of Bs must be < 100
,
Oct 28 2016
No objections, I think the config will be harder to read this way but since it does the same thing I don't feel strongly.
,
Oct 31 2016
#4 protobuf change is backwards compatible and hence preferred. Last Monday when I first heard of this idea, there was no "experiment_whitelist". Is that a CIA group?
,
Oct 31 2016
Yeah, a CIA group. It would be a way to override traffic splitting based on requesting user. jam@ offered to be a luci beta tester and asked for something like this.
,
Jan 23 2017
,
Jan 30 2017
go/cq-split-traffic is the design doc.
,
Jan 31 2017
,
Mar 22 2017
Issue 704268 has been merged into this issue.
,
Mar 22 2017
,
Apr 27 2017
,
May 4 2017
Removing M1-S1 since tandrii is mostly OOO during this sprint
,
May 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/e59214b5946446e01ce16206cfa6b0da9db19d0e commit e59214b5946446e01ce16206cfa6b0da9db19d0e Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 11 16:51:57 2017
,
May 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/1c5c72d1c7ee8401037322af02bb97c269917b62 commit 1c5c72d1c7ee8401037322af02bb97c269917b62 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 11 17:08:57 2017
,
May 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/f8613c994b0ebf8a9acc258993a44062c86f187c commit f8613c994b0ebf8a9acc258993a44062c86f187c Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 11 17:51:45 2017
,
May 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/f8613c994b0ebf8a9acc258993a44062c86f187c commit f8613c994b0ebf8a9acc258993a44062c86f187c Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 11 17:51:45 2017
,
May 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/9b3e79d3aa20c86836baa9cad331c7a5bdf3f97b commit 9b3e79d3aa20c86836baa9cad331c7a5bdf3f97b Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 11 17:58:32 2017
,
May 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/9b3e79d3aa20c86836baa9cad331c7a5bdf3f97b commit 9b3e79d3aa20c86836baa9cad331c7a5bdf3f97b Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 11 17:58:32 2017
,
May 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/191441dea46431636a5aaae5dc7b428b3469650b commit 191441dea46431636a5aaae5dc7b428b3469650b Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 11 18:13:54 2017
,
May 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/02cb532840ded22775c3dd8069bda3777f6b02af commit 02cb532840ded22775c3dd8069bda3777f6b02af Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 12 12:31:57 2017
,
May 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/fc02083efe5a4fb21635a4f3bb2a458cd93a3735 commit fc02083efe5a4fb21635a4f3bb2a458cd93a3735 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 12 12:35:17 2017
,
May 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/a95937eb27326dd2e72774e5a0d37bd765013140 commit a95937eb27326dd2e72774e5a0d37bd765013140 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 12 13:43:16 2017
,
May 15 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/6127eeb522fa831d0a51213fe8fce5f316eb4092 commit 6127eeb522fa831d0a51213fe8fce5f316eb4092 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon May 15 13:17:14 2017
,
May 18 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/83130b2522921408d54408f3cac4ef3348260fa2 commit 83130b2522921408d54408f3cac4ef3348260fa2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 18 12:09:18 2017
,
May 18 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/83130b2522921408d54408f3cac4ef3348260fa2 commit 83130b2522921408d54408f3cac4ef3348260fa2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 18 12:09:18 2017
,
May 18 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/5f720cb2268b4c5ee1b7169663ac804950ef410f commit 5f720cb2268b4c5ee1b7169663ac804950ef410f Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 18 18:22:41 2017
,
May 18 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/e6dcad0fd4a153dbcc571569daeb59d76d8eb041 commit e6dcad0fd4a153dbcc571569daeb59d76d8eb041 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 18 20:59:04 2017
,
May 18 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/e6dcad0fd4a153dbcc571569daeb59d76d8eb041 commit e6dcad0fd4a153dbcc571569daeb59d76d8eb041 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 18 20:59:04 2017
,
May 18 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/d33f11bc84c66dece6ee90182a20e8cd63df3819 commit d33f11bc84c66dece6ee90182a20e8cd63df3819 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu May 18 21:31:26 2017
,
May 23 2017
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/500891745b08cff241695b6e1ee346bea1cdf7e5 commit 500891745b08cff241695b6e1ee346bea1cdf7e5 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 08:42:14 2017
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/a3b1004cc35bc5b23e4694e8a99a90bb2b2f3adb commit a3b1004cc35bc5b23e4694e8a99a90bb2b2f3adb Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 09:19:06 2017
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/6194b1977e9db315b948ed07f8551a3ff8688245 commit 6194b1977e9db315b948ed07f8551a3ff8688245 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 09:42:55 2017
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/7be4e39b51ab78fefa529ed6f30814d0d9b7a706 commit 7be4e39b51ab78fefa529ed6f30814d0d9b7a706 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 10:10:01 2017
,
May 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/8b4222f63bd723d5ffc8519d13f9d7f7f5fd9051 commit 8b4222f63bd723d5ffc8519d13f9d7f7f5fd9051 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 26 08:09:42 2017
,
May 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/658cf50c4c499995d273dac842a30be05b1d2e1b commit 658cf50c4c499995d273dac842a30be05b1d2e1b Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 26 08:40:33 2017
,
May 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/9087c7965c364bb84df65c93ae6b12cba43fee69 commit 9087c7965c364bb84df65c93ae6b12cba43fee69 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 26 09:19:16 2017
,
May 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/db458c1ce3645ba20c54facc3b15c85e20a3e8ca commit db458c1ce3645ba20c54facc3b15c85e20a3e8ca Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 26 10:18:56 2017
,
May 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/384c5b88263380366ad9b02569300ec98db2d82d commit 384c5b88263380366ad9b02569300ec98db2d82d Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 26 12:02:33 2017
,
May 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/1c0ec566b3f4d47af2dfb8294d538ce815b2d7d2 commit 1c0ec566b3f4d47af2dfb8294d538ce815b2d7d2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 26 12:29:03 2017
,
May 30 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/7a2fa9595ea23591a2100a52581624a04719e18d commit 7a2fa9595ea23591a2100a52581624a04719e18d Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue May 30 10:40:37 2017
,
May 30 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/82f62f5c276bbd9d8da8e4ea562244bcb000858e commit 82f62f5c276bbd9d8da8e4ea562244bcb000858e Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 10:42:14 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/2407eaf550d775fe8101e6618cbba7610e8ed529 commit 2407eaf550d775fe8101e6618cbba7610e8ed529 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 10:48:32 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/107a334c839f4d4c60a0500e075830822d56de45 commit 107a334c839f4d4c60a0500e075830822d56de45 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 13:55:36 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/2cdae7250f3459ea761dceec00b8089f6b621b8d commit 2cdae7250f3459ea761dceec00b8089f6b621b8d Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 14:06:46 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/6ed0a2fd31aeaf48f089851ce024941221f07760 commit 6ed0a2fd31aeaf48f089851ce024941221f07760 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 14:08:56 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/82e238dd559e0a9b337ab8cffb6044c186317f42 commit 82e238dd559e0a9b337ab8cffb6044c186317f42 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 14:18:42 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/1eb3e54872162fca35c22d4c02e30cfd2ed18e2f commit 1eb3e54872162fca35c22d4c02e30cfd2ed18e2f Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 15:21:28 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/1eb3e54872162fca35c22d4c02e30cfd2ed18e2f commit 1eb3e54872162fca35c22d4c02e30cfd2ed18e2f Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 15:21:28 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/5d91d2569af3d56f02480235ea58f1b51c08c693 commit 5d91d2569af3d56f02480235ea58f1b51c08c693 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 17:30:35 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/1443fe55ff74f423b64e01027bcb9a50a6f46150 commit 1443fe55ff74f423b64e01027bcb9a50a6f46150 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 17:46:08 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/e6c6de357e996b5f910fba40168339b653ab0be2 commit e6c6de357e996b5f910fba40168339b653ab0be2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 18:26:52 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/e6c6de357e996b5f910fba40168339b653ab0be2 commit e6c6de357e996b5f910fba40168339b653ab0be2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 18:26:52 2017
,
May 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/7ef1fe3a7799e8c306352b27dedd8e0b837f18a9 commit 7ef1fe3a7799e8c306352b27dedd8e0b837f18a9 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 31 18:35:22 2017
,
Jun 1 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/c5a3aa5380b2e9b10bd5561bd0cf36aeee1f484b commit c5a3aa5380b2e9b10bd5561bd0cf36aeee1f484b Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Jun 01 13:58:03 2017
,
Jun 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/a32e13026bb8c09d418f3e54151269a0e19d96f8 commit a32e13026bb8c09d418f3e54151269a0e19d96f8 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 02 10:19:20 2017
,
Jun 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/afc3da5b2b5d63560f08768de084dd7e498d61a2 commit afc3da5b2b5d63560f08768de084dd7e498d61a2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 02 11:54:06 2017
,
Jun 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/afc3da5b2b5d63560f08768de084dd7e498d61a2 commit afc3da5b2b5d63560f08768de084dd7e498d61a2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 02 11:54:06 2017
,
Jun 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/4adcd0651c8a9ac824e1a6f2ec1cc8fba63314a3 commit 4adcd0651c8a9ac824e1a6f2ec1cc8fba63314a3 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 02 12:36:55 2017
,
Jun 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/287f3542ce2f9ae363f5559bcdb28450ab72f84b commit 287f3542ce2f9ae363f5559bcdb28450ab72f84b Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 02 14:24:13 2017
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/d09a1650ee371a9f7cc53dceae3bb7a77195c069 commit d09a1650ee371a9f7cc53dceae3bb7a77195c069 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 02 14:38:57 2017 A non-functional change to test new CQ config validator. Bug: 660385 Change-Id: Id8bee869af0cdd7e6c7d114623fda048d3597faf TBR=machenbach@chromium.org NOTRY=True Reviewed-on: https://chromium-review.googlesource.com/522070 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/d09a1650ee371a9f7cc53dceae3bb7a77195c069/infra/config/cq.cfg
,
Jun 6 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/9b2cad6fd1749f0cb7380f3738d33616ba2265fc commit 9b2cad6fd1749f0cb7380f3738d33616ba2265fc Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Jun 06 15:19:10 2017
,
Jun 6 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/3704a3d68815e173104ba1fbfeb522033e32f31c commit 3704a3d68815e173104ba1fbfeb522033e32f31c Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Jun 06 18:53:07 2017
,
Jun 6 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/df43eee34b948b1ef4d73a6b261c189a6333e62d commit df43eee34b948b1ef4d73a6b261c189a6333e62d Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Jun 06 20:05:50 2017
,
Jun 8 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/c54f0c7b52b36f480671c74e799ec3e023febcad commit c54f0c7b52b36f480671c74e799ec3e023febcad Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Jun 08 14:13:39 2017
,
Jun 8 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/b106f97db94a70351071ad8c055bf6dba28c7a11 commit b106f97db94a70351071ad8c055bf6dba28c7a11 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Jun 08 14:22:19 2017
,
Jun 8 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/6acb93b21bc029e606a7dd3ca7987e52f4d3d629 commit 6acb93b21bc029e606a7dd3ca7987e52f4d3d629 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Jun 08 14:54:47 2017
,
Jun 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/051f4ec3cc565152adebeea03cb53b02759e83fa commit 051f4ec3cc565152adebeea03cb53b02759e83fa Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 09 11:36:45 2017
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/2e82a4a302eb42df3ad359f5bdc73b4c62addfd5 commit 2e82a4a302eb42df3ad359f5bdc73b4c62addfd5 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 09 13:04:56 2017 Test CQ traffic splitting: default 50% w/o whitelist. Bug: 660385 Change-Id: I93109d95074379f0ed89801280ed43e2e37a7f45 No-Try: True No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/529304 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/2e82a4a302eb42df3ad359f5bdc73b4c62addfd5/infra/config/cq.cfg
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/951aee27ea6c73a579340453137e7ce31aeb93bf commit 951aee27ea6c73a579340453137e7ce31aeb93bf Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 09 13:12:08 2017 Fix typo in CQ.cfg TBR=sergiyb@google.com Bug: 660385 Change-Id: Ic6260c9074b605f95ae43d42f5f87ab59517cb07 No-Try: True No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/529127 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/951aee27ea6c73a579340453137e7ce31aeb93bf/infra/config/cq.cfg
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/951aee27ea6c73a579340453137e7ce31aeb93bf commit 951aee27ea6c73a579340453137e7ce31aeb93bf Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 09 13:12:08 2017 Fix typo in CQ.cfg TBR=sergiyb@google.com Bug: 660385 Change-Id: Ic6260c9074b605f95ae43d42f5f87ab59517cb07 No-Try: True No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/529127 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/951aee27ea6c73a579340453137e7ce31aeb93bf/infra/config/cq.cfg
,
Jun 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/444aa998f331b081de3cca06fa58bdd5df20fad2 commit 444aa998f331b081de3cca06fa58bdd5df20fad2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 09 13:15:56 2017
,
Jun 9 2017
Test 1: default 50% without whitelist - passed on https://chromium-review.googlesource.com/c/529247/ while https://chromium-review.googlesource.com/c/529226/ around the same time was scheduled with default linux trybot.
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/65038423cf4ef006f81ac63a154c93b9dcc219a4 commit 65038423cf4ef006f81ac63a154c93b9dcc219a4 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 09 13:51:13 2017 Test CQ traffic splitting with explicit percentage. TBR=sergiyb@chromium.org Bug: 660385 Change-Id: I040c770c2d601dc94011f103a126a51877011836 No-Try: True No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/529206 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/65038423cf4ef006f81ac63a154c93b9dcc219a4/infra/config/cq.cfg
,
Jun 9 2017
Test 2: explicit percentage at 100% -> passed https://chromium-review.googlesource.com/c/529067/
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/59e790180517c78478b9f8465fccbf2fa627bbf0 commit 59e790180517c78478b9f8465fccbf2fa627bbf0 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 09 13:59:11 2017 Test CQ traffic splitting with explicit percentage and group whitelist. TBR=sergiyb@chromium.org Bug: 660385 Change-Id: I6d685b09fb0f4e50af10c2aae5e59450b343cb4b No-Try: True No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/529227 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/59e790180517c78478b9f8465fccbf2fa627bbf0/infra/config/cq.cfg
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/3cea100052cfb8c37915ecae27fbfb9452d9d060 commit 3cea100052cfb8c37915ecae27fbfb9452d9d060 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 09 14:13:40 2017 Test CQ traffic splitting with explicit percentage and whitelist. Now with a group to whcih tAndrii doesn't belong. TBR=sergiyb@chromium.org Bug: 660385 Change-Id: I3ecf1f53fc207cfca6a33fbe934b7d9a8fe956b3 No-Try: True No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/529068 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/3cea100052cfb8c37915ecae27fbfb9452d9d060/infra/config/cq.cfg
,
Jun 9 2017
Test 3.1: with 100% and whitelist to which I belong -> passed. https://chromium-review.googlesource.com/c/529208/
,
Jun 9 2017
Test 3.2: with 100% and whitelist to which I don't belong -> passed https://chromium-review.googlesource.com/c/529069/
,
Jun 9 2017
Err, forgot to make a release to production.
,
Jun 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/a72884a8389213fe9705de87c6ad58a019e67704 commit a72884a8389213fe9705de87c6ad58a019e67704 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Jun 09 14:31:28 2017
,
Jun 9 2017
,
Jun 9 2017
,
Nov 8 2017
,
Jan 31 2018
,
Feb 13 2018
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by no...@chromium.org
, Oct 28 2016