New issue
Advanced search Search tips

Issue 660378 link

Starred by 1 user
Status: Fixed
Owner:
jkarlin@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 657830



Sign in to add a comment

Create separate timing metrics (page load and net) for H2, QUIC, and H1 protocols

Project Member Reported by jkarlin@chromium.org, Oct 28 2016 
There are a few reasons to do this. First, it allows QUIC and H2 developers to see the impact of their work (wins and regressions) at a high level. Second, it allows us to study the effect of loading changes on the protocols.

Comment 1 by jkarlin@chromium.org, Oct 31 2016

Summary: Create separate timing metrics (page load and net) for H2, QUIC, and H1 protocols (was: Create separate page load timing metrics for H2, QUIC, and H1 protocols)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb150114cab368d5fcb45b9e3ee8c8f7d500921b

commit bb150114cab368d5fcb45b9e3ee8c8f7d500921b
Author: jkarlin <jkarlin@chromium.org>
Date: Wed Nov 02 17:55:11 2016

Create page load timing metrics for H2/QUIC/H1 pages

This CL pipes connection information through the NavigationHandle so that it
can be logged by a new page load metrics observer.

BUG= 660378 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2457583007
Cr-Commit-Position: refs/heads/master@{#429333}

[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/chrome/browser/BUILD.gn
[add] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
[add] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h
[add] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/chrome/test/BUILD.gn
[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/content/browser/loader/navigation_resource_throttle.cc
[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/content/public/browser/navigation_handle.h
[modify] https://crrev.com/bb150114cab368d5fcb45b9e3ee8c8f7d500921b/tools/metrics/histograms/histograms.xml

Comment 3 by jkarlin@chromium.org, Nov 2 2016

Status: Fixed (was: Started)
►

Sign in to add a comment