New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660374 link

Starred by 1 user
Status: Fixed
Owner:
█ tschumann@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
ntp-dev+bugs@chromium.org
█ nepper@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Consider merging new-remote-sections fix into M55

Project Member Reported by tschumann@chromium.org, Oct 28 2016 
In M55, we don't persist new remote sections.
The fixes
https://codereview.chromium.org/2395273003
https://codereview.chromium.org/2402323002
https://codereview.chromium.org/2422633002

were landed the week after BP, but haven't been merged yet.
The code is been exercised on Canary (we recently launched a server-side Diwali section on Canary) and seems to be working well.

While M55 is already in Beta we should consider merging into M55. The promotion M55 stable is scheduled for Dec 6, so there's still time for beta testing.

Without these fixes, we cannot experiment with server-side sections like local stories (as the section does not get persisted across restarts).

Comment 1 by tschumann@chromium.org, Oct 28 2016 

To clarify the effect: additional remote sections might not be visible at all for a user (if the app got killed between the background fetch and the user opening the page) or they might disappear later (again, after a restart).

Comment 2 by tschumann@chromium.org, Nov 2 2016

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Nov 3 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 4 by fi...@chromium.org, Nov 4 2016

Labels: zine-triaged zine-client-sections-v1

Comment 5 by markusheintz@chromium.org, Nov 4 2016 

I merged all three CLs successfully into the M55 branch.

Comment 6 by treib@chromium.org, Nov 7 2016

Status: Fixed (was: Assigned)
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 7 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by tschumann@chromium.org, Nov 7 2016

Labels: -Merge-Approved-55 merge-merged-2883
►

Sign in to add a comment