New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660356 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 664981



Sign in to add a comment

Change data saver promo icon to blue (instead of normal chrome icon)

Project Member Reported by rachelis@google.com, Oct 28 2016

Issue description

We decided to change the data saver promo icon to blue, but it looks like we didn't track that change. Whoops! :) We should make that change now. 

Here's the original deck for reference:
https://docs.google.com/presentation/d/1dWIxBtAM6uX3oMCh_0mpq115KS1UAHpI4MbQOhrwkGs/edit#slide=id.g14dfee0594_0_1
 
Owner: megjab...@chromium.org
Status: Assigned (was: Untriaged)
Hey Megan, would you mind taking this on? Just sent a quick note with context but there are a few bits and pieces where the infobar UI doesn't quite match the spec. Thanks!
Ya I can take this on, but I'm doing campus recruiting this week so it won't make the M56 branch. Do we want it merged?
Megan, how difficult is it to merge a change? If it's not too difficult, it'd be nice to include in M56, but I don't see this as urgent and would be fine to include it in M57. Rachel or Rebecca, feel free to disagree if you have other thoughts here!
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbd68308efc017962dc15fa9fa6dc8a30bd885f6

commit cbd68308efc017962dc15fa9fa6dc8a30bd885f6
Author: megjablon <megjablon@chromium.org>
Date: Wed Nov 23 03:32:43 2016

Change the Data Saver infobar promo icon to blue

All of Data Saver's UI should use the blue icon. The infobar promo needs
to use the existing blue icon rather than the app_icon.

BUG= 660356 

Review-Url: https://codereview.chromium.org/2525843002
Cr-Commit-Position: refs/heads/master@{#434104}

[modify] https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6/build/android/lint/suppressions.xml
[rename] https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6/chrome/android/java/res/drawable-hdpi/infobar_chrome.png
[rename] https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6/chrome/android/java/res/drawable-mdpi/infobar_chrome.png
[rename] https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6/chrome/android/java/res/drawable-xhdpi/infobar_chrome.png
[rename] https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6/chrome/android/java/res/drawable-xxhdpi/infobar_chrome.png
[rename] https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6/chrome/android/java/res/drawable-xxxhdpi/infobar_chrome.png
[modify] https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionPromoInfoBar.java
[modify] https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6/chrome/browser/android/resource_id.h

Labels: Merge-Request-56
Status: Started (was: Assigned)

Comment 6 by dimu@chromium.org, Nov 23 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Status: Fixed (was: Started)
Blocking: 664981
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-56 Merge-Merged

Sign in to add a comment