New issue
Advanced search Search tips

Issue 660354 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

lint_test_expectations.py appears to be broken

Project Member Reported by phoglund@chromium.org, Oct 28 2016

Issue description

Version: --
OS: linux

What steps will reproduce the problem?
(1) Modify third_party/WebKit/LayoutTests/TestExpectations (note, I did this from my regular Chrome checkout)
(2) git commit
(3) git cl upload

What is the expected output?
Should work or actually lint the file

What do you see instead?
AttributeError raised: '_Environment' object has no attribute 'InitializeLogging'
Traceback (most recent call last):
  File "/usr/local/google/home/phoglund/dev/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py", line 143, in main
    exit_status = run_checks(host, options, stderr)
  File "/usr/local/google/home/phoglund/dev/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py", line 111, in run_checks
    failures.extend(lint(host, options))
  File "/usr/local/google/home/phoglund/dev/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py", line 51, in lint
    ports_to_lint = [host.port_factory.get(name) for name in host.port_factory.all_port_names(options.platform)]
  File "/usr/local/google/home/phoglund/dev/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 169, in get
    return cls(self._host, port_name, options=options, **kwargs)
  File "/usr/local/google/home/phoglund/dev/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py", line 297, in __init__
    devil_env.config.InitializeLogging(
AttributeError: '_Environment' object has no attribute 'InitializeLogging'

Please use labels and text to provide additional information.

 
Status: WontFix (was: Untriaged)
Hm, never mind, looks like a gclient sync fixed it.

Sign in to add a comment