Simplify Profile::IsNewProfile if possible |
|
Issue descriptionThe TODO in Profile::IsNewProfile [1] says about the condition representing the return value: "revisit this when [ bug 22142 ] (unifying the profile import code) is fixed" Bug 22142 is fixed. Is there anything to revisit? Should the TODO just be dropped? Cc-ing gab@ who fixed bug 22142 and anthonyvd@ as one of the OWNERS of this code. [1] https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile.cc?rcl=0&l=207-208
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa3bd8439be5b75baf0182f0157214a7d2869256 commit aa3bd8439be5b75baf0182f0157214a7d2869256 Author: vabr <vabr@chromium.org> Date: Fri Oct 28 12:18:58 2016 Associate a TODO with a bug instead of a person There is a TODO in profile.cc assigned to dconnelly@. dconnelly@ left Chromium, so the TODO got a new tracking bug and is being associated to it rather than to a no longer active developer. BUG=660346,543839 TBR=anthonyvd@chromium.org Review-Url: https://codereview.chromium.org/2461653002 Cr-Commit-Position: refs/heads/master@{#428341} [modify] https://crrev.com/aa3bd8439be5b75baf0182f0157214a7d2869256/chrome/browser/profiles/profile.cc |
|
►
Sign in to add a comment |
|
Comment 1 by vabr@chromium.org
, Oct 28 2016