New issue
Advanced search Search tips

Issue 660338 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Return actual mount status (readonly) from cros_disk

Project Member Reported by yamaguchi@chromium.org, Oct 28 2016

Issue description

Mount() in cros_disks DBus service doesn't return any values, but instead sends a signal when it's finished mounting (or failed) currently the signal doesn't have information about what mount options (ro/rw, especially) was applied for each mount path.
Current implementation is to have DiskMountManager memorizes what parameter it passed when requesting mount to cros_disks for each volume (identified by its device path).
It can break by a race condition when multiple mount operations are conducted for the same mount path / volume in a short time. It's cleaner to have MountComplete signal convey the actual mount options it applied.
 

Comment 1 by sashab@chromium.org, Feb 24 2018

Labels: CrOS-FilesApp-CodeHealth

Comment 2 by sashab@chromium.org, Feb 24 2018

Labels: -CrOS-FilesApp-CodeHealth CrOS-FilesApp

Comment 3 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp
Owner: ----
Status: Available (was: Assigned)
Cc: amistry@chromium.org dats@chromium.org
Labels: CrOSFilesCategory-CodeHealth

Sign in to add a comment