Issue 660331 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ derekjchow@chromium.org Last visit > 30 days ago
Closed:	Dec 2016
Components:	Chromecast
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Bug

Remove the inheritance of CastMediaBlocker -> WebContentsObserver

Project Member Reported by zqzh...@chromium.org, Oct 28 2016

Issue description

Since MediaSession is going to be decoupled from WebContents, CastMediaBlocker needs corresponding changes.

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c3526bb1e5d954c7194ff44a7109c3bf77df49c

commit 3c3526bb1e5d954c7194ff44a7109c3bf77df49c
Author: derekjchow <derekjchow@chromium.org>
Date: Thu Dec 01 17:58:42 2016

[Chromecast] Simplify CastMediaBlocker.

Remove WebContentsObserver from CastMediaBlocker.

BUG= 660331 

Review-Url: https://codereview.chromium.org/2535343003
Cr-Commit-Position: refs/heads/master@{#435647}

[modify] https://crrev.com/3c3526bb1e5d954c7194ff44a7109c3bf77df49c/chromecast/browser/cast_media_blocker.cc
[modify] https://crrev.com/3c3526bb1e5d954c7194ff44a7109c3bf77df49c/chromecast/browser/cast_media_blocker.h
[modify] https://crrev.com/3c3526bb1e5d954c7194ff44a7109c3bf77df49c/chromecast/browser/cast_media_blocker_browsertest.cc
[modify] https://crrev.com/3c3526bb1e5d954c7194ff44a7109c3bf77df49c/chromecast/browser/cast_media_blocker_unittest.cc

Comment 2 by derekjchow@chromium.org, Dec 12 2016

Status: Fixed (was: Assigned)

►

Issue 660331 link

Issue metadata

Remove the inheritance of CastMediaBlocker -> WebContentsObserver

Issue description

Comment 1 by bugdroid1@chromium.org, Dec 1 2016

Comment 1 Deleted

Comment 2 by derekjchow@chromium.org, Dec 12 2016

Comment 2 Deleted

Sign in to add a comment