Issue metadata
Sign in to add a comment
|
Content blurred and shifted when filter: brightness applied
Reported by
shuto...@gmail.com,
Oct 28 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2902.0 Safari/537.36 Steps to reproduce the problem: 1. Open Chrome 55 or 56. 2. Install Dark Reader extension. 3. Open http://serverfault.com/questions/162018/force-ssh-to-use-a-specific-shell 4. Open extension popup, play with filter settings. Or instead of installing the extension: 2. Go to http://serverfault.com/questions/162018/force-ssh-to-use-a-specific-shell 3. Add `-webkit-filter: brightness(90%);` to `<html>` element. What is the expected behavior? Text is always clear. What went wrong? Most of the time text is blurred. Did this work before? Yes 54.0.2840.71 m (64-bit) Does this work in other browsers? Yes Chrome version: 56.0.2902.0 Channel: beta OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0 Reported from here https://github.com/alexanderby/darkreader/issues/45 Reproduced in Chrome 55 and 56, Windows 10.
,
Nov 1 2016
Unable to reproduce this issue using dark reader extension on Windows 10 using latest canary M56-56.0.2905.0, latest beta M55-55.0.2883.28 and stable version M54-54.0.2840.71. Please check the attached screenshots. In order to further triage this issue and provide the steps on how to use method 2. Thank You...
,
Nov 2 2016
,
Nov 2 2016
Able to reproduce this issue on windows 10-Desktop on latest chrome canary version 56.0.2906.0 Issue is broken in M55. Bisect Info: =========== Good build : 55.0.2872.0, Revision Range(420859) Bad build : 55.0.2873.0, Revision Range(421052) After executing the per-revision-bisect script, i got the following CL's between good and bad build versions ============================================ https://chromium.googlesource.com/chromium/src/+log/38d12538c8af0b8afbf9c5b586b10902b9ba1303..ef06887f125941e96ab19fba834d9027d36d4c88 The suspecting Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/ef06887f125941e96ab19fba834d9027d36d4c88 From the above CL suspecting the below change --------------------------- https://codereview.chromium.org/2358203002 schenney@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner. Note: ------ This issue is not reproduced in Windows 10-Dell Laptop, MacBook Air - 10.11.6 and Ubuntu 14.04 desktop. Adding release block stable against M-56 as it is broken in M-55, please feel free to modify,if it is not appropriate. Thank You...
,
Nov 2 2016
On Linux the filter is disabling LCD text, which is not surprising. I'm guessing that on Windows 10 this is a more significant effect, but I don't have a Windows 10 machine to test on. A team member reports not seeing the issue on Windows 10 in M56. Do you have any customized font rendering settings, or a high DPI display on your Windows 10 machine? We need to somehow isolate the circumstances that are breaking your content. Does having the filter on another scrolling element cause problems only for that element? Or it is a problem on the whole page?
,
Nov 10 2016
shutovby@ - Could you please respond for the comment #6 ?
,
Nov 10 2016
schenney@ - I tried it on two Windows 10 devices: - desktop with Intel HD Graphics 530 without custom text settings. - laptop with GT 750M with text/apps size set to 150%. On both devices for Stable Chrome 1px blur is noticeable but is not critical (as you explained this is caused by disabling subpixel rendering). Issue happens on both devices in Chrome Canary, blur is about 3px. Again this happens on http://serverfault.com/questions/162018/force-ssh-to-use-a-specific-shell , on http://serverfault.com/ it works well. Issue is seen for the whole page as soon as I add `-webkit-filter: brightness(100%);` to root `<html>` element. I'll thy to provide some minimal page. IMPORTANT: Just noticed that issue happens for borders, images, everything is blurred by 1px horizontally, compare two attached images.
,
Nov 10 2016
The issue certainly reproduces on Canary (56.0.2915.0) Win 7. On the http://serverfault.com/questions/162018/force-ssh-to-use-a-specific-shell page the content moves in a very non-linear manner when filter: brightness(100%) is applied to the html element. The left side of the page goes right a pixel or 2, and the right side of the page goes left a pixel or 2, and there is a column that gets squashed out.
,
Nov 10 2016
,
Nov 10 2016
By "column" do you mean a column of pixels? I noticed that it's less noticeable in GPU rasterization (which has large, wide tiles). But the artifacts don't seem to be happening on tile boundaries. It's as if there's a rounding error in the tile's texture coordinates or something, causing a slight stretch. I'll try a bisect.
,
Nov 10 2016
According to bisect-builds, I get a regression in this range: https://chromium.googlesource.com/chromium/src/+log/6f267f635b978d7f4fe4899c302c2126978dc102..22debab7ebb8b7e7a3b96c416ed593f047af5169 which includes schenney@'s change above as the only likely culprit. (I didn't use the per-revision one yet, 'cos I'm old school). schenney@, did you try reverting your change locally and reproing?
,
Nov 10 2016
,
Nov 14 2016
Able to reproduce the issue on win10 chrome version 56.0.2919.1 canary schenney@, Could you please take a look
,
Nov 22 2016
Able to reproduce the issue on win10 chrome canary version 57.0.2926.0 . schenney@, Could you please look into this. Thanks!
,
Nov 23 2016
Yes, it's on my growing list of things to look into.
,
Dec 1 2016
Looked at this again today. Regarding comment #14 and comment #15, are you seeing the text get a little blurry, or the text moving? Blurry text is expected due to the loss of sub-pixel anti-aliasing. Moving text and other content (borders etc) is a bug.
,
Dec 8 2016
Somehow this has been fixed and no longer occurs on Win 7, Win 10, M55 or trunk. The text does degrade a little but that's expected due to loss of subpixel AA. Add a comment if you detect the issue still occurring.
,
Dec 8 2016
,
Jan 19 2017
This bug has moved to stable, so I have found out how to reproduce it. Open devtools on current page, set `filter: brightness(100%); text-indent: -999999em;` to <html> element. You may ask what's the sense of setting such a large text indent, but for some reason Stackoverflow.com logo has such an indent (element `#hlogo a`). For example filters on this page look blurry until you remove `text-indent` http://stackoverflow.com/questions/19648092/d3-multiple-onclick-events |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by samli@chromium.org
, Oct 30 2016