New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660296 link

Starred by 1 user
Status: Fixed
Owner:
█ yabinh@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
█ aelias@chromium.org
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

setComposingText() and commitText() tangle together

Project Member Reported by yabinh@chromium.org, Oct 28 2016 
When |text| is empty(), ReplicaInputConnection#commitText(text, int) and ThreadedInputConnection#commitText(text, int) will call InputMethodController::setComposition(). It can work, but makes the code messy. They should call InputMethodController::commitText().
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c04b06d49b5554e9a24a32a4b964ca651212b34

commit 7c04b06d49b5554e9a24a32a4b964ca651212b34
Author: yabinh <yabinh@chromium.org>
Date: Fri Oct 28 07:41:04 2016

Untangel setComposingText() and commitText()

Make ReplicaInputConnection#commitText() and
ThreadedInputConnection#commitText() call
InputMethodController::commitText() instead of
InputMethodController::setComposition() when text is empty.

BUG= 660296 

Review-Url: https://codereview.chromium.org/2458773005
Cr-Commit-Position: refs/heads/master@{#428310}

[modify] https://crrev.com/7c04b06d49b5554e9a24a32a4b964ca651212b34/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java
[modify] https://crrev.com/7c04b06d49b5554e9a24a32a4b964ca651212b34/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

Comment 2 by yabinh@chromium.org, Oct 31 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment