New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660288 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Out until 24 Jan
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebNavigationApiTest.ServerRedirect flaky

Project Member Reported by tyoshino@chromium.org, Oct 28 2016

Issue description

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/58375

Assigning to the author jochen@
https://codereview.chromium.org/7488011

[ RUN      ] WebNavigationApiTest.ServerRedirect
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[18994:18994:1027/212151:WARNING:persistent_histogram_allocator.cc(502)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).
[18994:18994:1027/212151:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected
[18994:18994:1027/212151:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected
[18994:18994:1027/212152:WARNING:password_store_factory.cc(248)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[1:2:1027/212152:WARNING:persistent_histogram_allocator.cc(502)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).
[1:2:1027/212153:WARNING:persistent_histogram_allocator.cc(502)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).
[19204:19256:1027/212153:WARNING:persistent_histogram_allocator.cc(502)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).
[1:2:1027/212153:WARNING:persistent_histogram_allocator.cc(502)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).
[18994:19187:1027/212154:WARNING:simple_synchronous_entry.cc(1054)] Could not open platform files for entry.
[18994:18994:1027/212154:INFO:CONSOLE(0)] "[FAIL] serverRedirect: Received unexpected event 'onErrorOccurred':{"error":"net::ERR_ABORTED","frameId":0,"processId":-1,"tabId":0,"timeStamp":0,"url":"http://www.a.com:52801/extensions/api_test/webnavigation/serverRedirect/a.html"}
Error
    at Object.<anonymous> (extensions::test:105:11)
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at captureEvent (chrome-extension://olfmkcamajdpddlocfookaeadjdafmlm/framework.js:194:17)
    at chrome-extension://olfmkcamajdpddlocfookaeadjdafmlm/framework.js:231:5
    at EventImpl.dispatchToListener (extensions::event_bindings:388:22)
    at Event.publicClassPrototype.(anonymous function) [as dispatchToListener] (extensions::utils:151:26)
    at EventImpl.dispatch_ (extensions::event_bindings:372:35)
    at dispatchArgs (extensions::event_bindings:244:26)
    at dispatchEvent (extensions::event_bindings:253:7)", source: chrome-extension://olfmkcamajdpddlocfookaeadjdafmlm/test_serverRedirect.html (0)
../../chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:410: Failure
Value of: RunExtensionTest("webnavigation/serverRedirect")
  Actual: false
Expected: true
Failed 1 of 1 tests
[  FAILED  ] WebNavigationApiTest.ServerRedirect, where TypeParam =  and GetParam() =  (4836 ms)

 

Comment 1 by jochen@chromium.org, Oct 28 2016

Cc: jochen@chromium.org
Owner: nasko@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ee2a873ed1a26de90ff2219cab5f7c673641a40

commit 0ee2a873ed1a26de90ff2219cab5f7c673641a40
Author: tyoshino <tyoshino@chromium.org>
Date: Fri Oct 28 08:22:55 2016

Disable flaky test WebNavigationApiTest.ServerRedirect on Linux

TBR=nasko@chromium.org
BUG= 660288 

Review-Url: https://codereview.chromium.org/2454323003
Cr-Commit-Position: refs/heads/master@{#428318}

[modify] https://crrev.com/0ee2a873ed1a26de90ff2219cab5f7c673641a40/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Comment 4 by jam@chromium.org, Feb 23 2017

This is flaky in other places too, just linux is more likely to hit it because it's faster.

i.e. see 
https://luci-milo.appspot.com/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/356660

On Windows debug builds it also repros locally sometimes, but only with PlzNavigate on. On Mac release builds, it repros with PlzNavigate most times.

Comment 5 by jam@chromium.org, Feb 23 2017

Summary: WebNavigationApiTest.ServerRedirect flaky (was: WebNavigationApiTest.ServerRedirect failed on Linux Tests (dbg) bot)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8d527fa602efdd841ab3d4bfbcec0e7d02a35fd

commit c8d527fa602efdd841ab3d4bfbcec0e7d02a35fd
Author: jam <jam@chromium.org>
Date: Thu Feb 23 21:17:24 2017

Disable WebNavigationApiTest.ServerRedirect which is flaky on more than Linux.

BUG= 660288 
TBR=nasko

Review-Url: https://codereview.chromium.org/2715673003
Cr-Commit-Position: refs/heads/master@{#452632}

[modify] https://crrev.com/c8d527fa602efdd841ab3d4bfbcec0e7d02a35fd/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6620ff85a6da7b582091968ee7d01326ad3259a5

commit 6620ff85a6da7b582091968ee7d01326ad3259a5
Author: Nasko Oskov <nasko@chromium.org>
Date: Thu Aug 03 18:48:44 2017

Enable WebNavigationApiTest.ServerRedirect

This test passes with iteration count of 100 locally. It should not be
flaky, but let's try and see.

Bug:  660288 
Change-Id: I8f190be7f6b6639e048ea59f040ca0421c3b51bd
Reviewed-on: https://chromium-review.googlesource.com/600492
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491805}
[modify] https://crrev.com/6620ff85a6da7b582091968ee7d01326ad3259a5/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

[ RUN      ] WebNavigationApiTest.ServerRedirect
[11286:8451:0804/054923.620627:WARNING:notification_platform_bridge_mac.mm(514)] AlertNotificationService: XPC connection invalidated.
[11286:775:0804/054925.216964:INFO:CONSOLE(0)] "[FAIL] serverRedirect: Received unexpected event 'onErrorOccurred':{"error":"net::ERR_ABORTED","frameId":0,"processId":-1,"tabId":0,"timeStamp":0,"url":"http://www.a.com:55998/extensions/api_test/webnavigation/serverRedirect/a.html"}
Error
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at captureEvent (chrome-extension://okljdpebnafglodgmnchdbdpdnllijjh/_test_resources/api_test/webnavigation/framework.js:194:17)
    at chrome-extension://okljdpebnafglodgmnchdbdpdnllijjh/_test_resources/api_test/webnavigation/framework.js:231:5
    at EventImpl.dispatchToListener (extensions::event_bindings:403:22)
    at Event.publicClassPrototype.(anonymous function) [as dispatchToListener] (extensions::utils:140:26)
    at EventImpl.dispatch_ (extensions::event_bindings:387:35)
    at dispatchArgs (extensions::event_bindings:260:26)
    at dispatchEvent (extensions::event_bindings:269:7)", source: chrome-extension://okljdpebnafglodgmnchdbdpdnllijjh/test_serverRedirect.html (0)
../../chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:404: Failure
Value of: RunExtensionTest("webnavigation/serverRedirect")
  Actual: false
Expected: true
Failed 1 of 1 tests
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c137eb4c94efa2f4b60700690ea4000b024dde58

commit c137eb4c94efa2f4b60700690ea4000b024dde58
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Aug 04 13:16:27 2017

Revert "Enable WebNavigationApiTest.ServerRedirect"

This reverts commit 6620ff85a6da7b582091968ee7d01326ad3259a5.

Reason for revert: flaky on Mac (https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/3516)



Original change's description:
> Enable WebNavigationApiTest.ServerRedirect
> 
> This test passes with iteration count of 100 locally. It should not be
> flaky, but let's try and see.
> 
> Bug:  660288 
> Change-Id: I8f190be7f6b6639e048ea59f040ca0421c3b51bd
> Reviewed-on: https://chromium-review.googlesource.com/600492
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Commit-Queue: Nasko Oskov <nasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491805}

TBR=nasko@chromium.org,alexmos@chromium.org

Change-Id: If1d0082640f0b69c193792dc108045f8cc7dd41d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  660288 
Reviewed-on: https://chromium-review.googlesource.com/602307
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492006}
[modify] https://crrev.com/c137eb4c94efa2f4b60700690ea4000b024dde58/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Cc: clamy@chromium.org
Components: UI>Browser>Navigation Platform>Extensions>API
i think this is a race somewhere in plz navigate. What happens is that this test opens a tab with about:blank and then navigates to a site (say example.com). The expected sequence of events for the navigation to example.com would be

Start provisional load example.com
Commit example.com
...

but occasionally it's

Start provisional load example.com
Provisional load failed (net::ERR_ABORT)
Start provisional load example.com
Commit example.com
...

indicating that a process swap took place
I think this is likely the DidStopLoading/NavigationHandle commit race case (or a race with the commit of about:blank).
Project Member

Comment 13 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7678c8ace3a3a31cb49225afd9200b72fe22b7aa

commit 7678c8ace3a3a31cb49225afd9200b72fe22b7aa
Author: Jochen Eisinger <jochen@chromium.org>
Date: Mon May 07 15:47:34 2018

Remove suggested filename plumbing

The codepath is no longer used, instead, we just navigate to cross
origin URLs.

BUG= 831073 , 823639 , 660288 

Change-Id: I6a347a11e84539ad73d2b0b6aaaa1cc97d0b6118
Reviewed-on: https://chromium-review.googlesource.com/1016906
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556455}
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/download/download_ui_controller.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/extensions/extension_view_host.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/android/external_protocol_dialog_android.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/browser_navigator_params.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/browser_navigator_params.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/chrome/test/data/extensions/api_test/webnavigation/download/test_download.js
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/download/internal/common/in_progress_download_manager.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/download/internal/common/resource_downloader.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/download/internal/common/resource_downloader.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/download/public/common/in_progress_download_manager.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/intercept_navigation_throttle.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/navigation_params.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/navigation_params.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/components/navigation_interception/navigation_params_android.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/devtools_url_loader_interceptor.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/download/download_request_core.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/blocked_scheme_navigation_throttle.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/form_submission_throttle_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_controller_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigator.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/navigator_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/frame_host/render_frame_proxy_host.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/navigation_loader_util.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/navigation_loader_util.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/common/frame_messages.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/common/navigation_params.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/common/navigation_params.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/browser/navigation_controller.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/browser/navigation_handle.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/browser/navigation_handle.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/browser/page_navigator.h
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/public/test/render_view_test.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/shell/browser/shell.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/extensions/browser/extension_navigation_throttle.cc
[delete] https://crrev.com/72aef1a4cea800fff0d5375c284c6d071cf3d46c/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt
[delete] https://crrev.com/72aef1a4cea800fff0d5375c284c6d071cf3d46c/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-block-crossorigin.html
[modify] https://crrev.com/7678c8ace3a3a31cb49225afd9200b72fe22b7aa/third_party/blink/renderer/core/loader/frame_loader.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b398e710141fcbeddf844efef6b70de0a30648b8

commit b398e710141fcbeddf844efef6b70de0a30648b8
Author: Nasko Oskov <nasko@chromium.org>
Date: Tue Jun 12 18:30:15 2018

Enable WebNavigationApiTest.ServerRedirect test.

This test was flaky due to a race condition in navigation code, which
has now been fixed. Let's try to enable it and see if the fix has helped
deflake this test.

Bug:  660288 
Change-Id: I2d8377e42172d30b3af19f23c632d09c3e99f5f3
Reviewed-on: https://chromium-review.googlesource.com/1097555
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566510}
[modify] https://crrev.com/b398e710141fcbeddf844efef6b70de0a30648b8/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Comment 15 by nasko@chromium.org, Jun 13 2018

Status: Fixed (was: Assigned)
After a day or so it seems there are no flakes. Resolving this as fixed.
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f27798f4413b6f5e01b3c07aba49b9717e3b0cee

commit f27798f4413b6f5e01b3c07aba49b9717e3b0cee
Author: Nasko Oskov <nasko@chromium.org>
Date: Fri Jun 15 16:41:50 2018

Enable WebNavigationApiTest.Download test.

This test was flaky due to a race condition in navigation code, which
has now been fixed. Let's try to enable it and see if the fix has helped
deflake this test.

Bug:  660288 
Change-Id: Id5d74179b9719d97f712277d2fe2380b2235d74f
Reviewed-on: https://chromium-review.googlesource.com/1102569
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567688}
[modify] https://crrev.com/f27798f4413b6f5e01b3c07aba49b9717e3b0cee/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Sign in to add a comment