Issue 660281 link

Starred by 1 user

Issue metadata

Status:	Started
Owner:	peria@chromium.org
Cc:	lfg@chromium.org
Components:	Blink>Bindings
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug
Hotlist-Bindings-IDLCompiler

Blocked on:
issue 839389

Participants' hotlists:
Hotlist-Bindings-IDLCompiler

Make binding templates and scripts more readable

Project Member Reported by peria@chromium.org, Oct 28 2016

Issue description

After the big reformatting ( http://crbug.com/563793 ), we still leave binding templates WebKit like style, and it means our generated code is still in WebKit like style.
So we would like to reformat binding templates to match with Chromium like style.

This issue is a tracking those changes for the reformatting.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807695c59479aaaec619bb72c60a32f1c6adb779

commit 807695c59479aaaec619bb72c60a32f1c6adb779
Author: peria <peria@chromium.org>
Date: Fri Oct 28 09:23:37 2016

Reformat template files for Interface

I'm planning to change the format of templates as follows:
- Interfaces (this CL)
- Methods (https://codereview.chromium.org/2460563002/)
- Attributes (https://codereview.chromium.org/2449043007/)
- Others (https://codereview.chromium.org/2452403002/)

Because reformatting them at once will be huge, especially
for V8TestObject.cpp, and it can costs network if reverted.
https://codereview.chromium.org/2446213002/
so I'd like to split it into few changes.

BUG=660281

Review-Url: https://codereview.chromium.org/2454133002
Cr-Commit-Position: refs/heads/master@{#428323}

[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.h
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
[modify] https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b912a1b09ed861cb2988c865355825f852dd300f

commit b912a1b09ed861cb2988c865355825f852dd300f
Author: peria <peria@chromium.org>
Date: Fri Oct 28 11:11:33 2016

Reformat methods.cpp.tmpl

I'm planning to change the format of templates as follows:
- Interfaces (https://codereview.chromium.org/2454133002/)
- Methods (this CL)
- Attributes (https://codereview.chromium.org/2449043007/)
- Others (https://codereview.chromium.org/2452403002/)

Because reformatting them at once will be huge, especially
for V8TestObject.cpp, and it can costs network if reverted.
https://codereview.chromium.org/2446213002/
so I'd like to split it into few changes.

BUG=660281

Review-Url: https://codereview.chromium.org/2460563002
Cr-Commit-Position: refs/heads/master@{#428332}

[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1b605811f41370d6cdc6b1ece79796f561352cc

commit a1b605811f41370d6cdc6b1ece79796f561352cc
Author: peria <peria@chromium.org>
Date: Fri Oct 28 12:37:21 2016

Reformat methods.cpp.tmpl

I'm planning to change the format of templates as follows:
- Interfaces (https://codereview.chromium.org/2454133002/)
- Methods (https://codereview.chromium.org/2460563002/)
- Attributes (this CL)
- Others (https://codereview.chromium.org/2452403002/)

Because reformatting them at once will be huge, especially
for V8TestObject.cpp, and it can costs network if reverted.
https://codereview.chromium.org/2446213002/
so I'd like to split it into few changes.

BUG=660281

Review-Url: https://codereview.chromium.org/2449043007
Cr-Commit-Position: refs/heads/master@{#428343}

[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250b1ec6eeeb7bdeca5d678649073eff8a02a425

commit 250b1ec6eeeb7bdeca5d678649073eff8a02a425
Author: peria <peria@chromium.org>
Date: Fri Oct 28 14:21:17 2016

Reformat template files for bindings

I'm planning to change the format of templates as follows:
- Interfaces (https://codereview.chromium.org/2454133002/)
- Methods (https://codereview.chromium.org/2460563002/)
- Attributes (https://codereview.chromium.org/2449043007/)
- Others (this CL)

Because reformatting them at once will be huge, especially
for V8TestObject.cpp, and it can costs network if reverted.
https://codereview.chromium.org/2446213002/
so I'd like to split it into few changes.

BUG=660281

Review-Url: https://codereview.chromium.org/2452403002
Cr-Commit-Position: refs/heads/master@{#428364}

[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/union_container.h.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/templates/utilities.cpp.tmpl
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
[modify] https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h

Comment 5 by peria@chromium.org, Mar 6 2017

Summary: Make binding templates and scripts more readable (was: Reformat binding templates)

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2100813cb0c0d18a87434921433fda24d04cda16

commit 2100813cb0c0d18a87434921433fda24d04cda16
Author: peria <peria@chromium.org>
Date: Wed Mar 15 10:28:45 2017

Refactoring of template files for callback functions
- Fix invalid format (put a space after ::create())
- Fix an indentation
- Replace m_scriptState->isolate() with isolate
- Move the empty implementation of trace() to .h.tmpl file
- Fold static long lines.

BUG=660281

Review-Url: https://codereview.chromium.org/2755603003
Cr-Commit-Position: refs/heads/master@{#457048}

[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
[modify] https://crrev.com/2100813cb0c0d18a87434921433fda24d04cda16/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff8bf75385335e8da5261a179e70af52f2af5c49

commit ff8bf75385335e8da5261a179e70af52f2af5c49
Author: peria <peria@chromium.org>
Date: Thu Mar 16 08:28:44 2017

Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines

BUG=660281

Review-Url: https://codereview.chromium.org/2758463002
Cr-Commit-Position: refs/heads/master@{#457372}

[modify] https://crrev.com/ff8bf75385335e8da5261a179e70af52f2af5c49/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/ff8bf75385335e8da5261a179e70af52f2af5c49/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/ff8bf75385335e8da5261a179e70af52f2af5c49/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/ff8bf75385335e8da5261a179e70af52f2af5c49/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f7af87790319208abf7f4554e32a868b91b478d

commit 8f7af87790319208abf7f4554e32a868b91b478d
Author: peria <peria@chromium.org>
Date: Fri Mar 24 11:26:12 2017

Rename CachedAccessorCallback methods in generated code

This method is used in creating function templates to get (or generate)
a property key, and this method itself is not registered as a callback function.
Hence, the name with 'Callback' suffix was confusing, and this CL changes
the name to be 'CachedPropertyKey' like getter functions.

Note:
On current trunk code, V8Window::documentCachedAccessorCallback()
is the only method which is actually renamed.

BUG=660281

Review-Url: https://codereview.chromium.org/2768393004
Cr-Commit-Position: refs/heads/master@{#459389}

[modify] https://crrev.com/8f7af87790319208abf7f4554e32a868b91b478d/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp
[modify] https://crrev.com/8f7af87790319208abf7f4554e32a868b91b478d/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
[modify] https://crrev.com/8f7af87790319208abf7f4554e32a868b91b478d/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/8f7af87790319208abf7f4554e32a868b91b478d/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
[modify] https://crrev.com/8f7af87790319208abf7f4554e32a868b91b478d/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/8f7af87790319208abf7f4554e32a868b91b478d/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

Comment 9 by peria@chromium.org, May 3 2018

Blockedon: 839389

Comment 10 by peria@chromium.org, May 25 2018

Labels: Hotlist-Bindings-IDLCompiler

►

Issue 660281 link

Issue metadata

Make binding templates and scripts more readable

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 28 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Oct 28 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Oct 28 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 28 2016

Comment 4 Deleted

Comment 5 by peria@chromium.org, Mar 6 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Mar 15 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Mar 16 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Mar 24 2017

Comment 8 Deleted

Comment 9 by peria@chromium.org, May 3 2018

Comment 9 Deleted

Comment 10 by peria@chromium.org, May 25 2018

Comment 10 Deleted

Sign in to add a comment