PrerenderBrowserTest.AutosigninInPrerenderer has been flaky |
|||
Issue descriptionExample of failing builds. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/58371 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/58365 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/58363 https://chromium.googlesource.com/chromium/src/+/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845%5E%21/ might be the cause. Please take a look, vasilii.
,
Oct 28 2016
Confirmed. The problem is that the prerender may fully load or be interrupted before. It doesn't matter for the test logic. However, it was checked by default.
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44655c02fec42900c8379e49bb83fa8e8b9629ff commit 44655c02fec42900c8379e49bb83fa8e8b9629ff Author: vasilii <vasilii@chromium.org> Date: Fri Oct 28 15:12:54 2016 Fix PrerenderBrowserTest.AutosigninInPrerenderer flakiness. The test checked that the prerender is stopped before the page is fully loaded. It's not guaranteed and its unrelated to the test logic. BUG= 660278 Review-Url: https://codereview.chromium.org/2458953002 Cr-Commit-Position: refs/heads/master@{#428374} [modify] https://crrev.com/44655c02fec42900c8379e49bb83fa8e8b9629ff/chrome/browser/prerender/prerender_browsertest.cc
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cce92f9630364bbab9c37478ae7b24f25cf3ffa1 commit cce92f9630364bbab9c37478ae7b24f25cf3ffa1 Author: vasilii <vasilii@chromium.org> Date: Mon Nov 07 13:02:57 2016 Fix potential flakiness in PrerenderBrowserTest.AutosigninInPrerenderer This is a follow-up to https://codereview.chromium.org/2458953002. BUG= 660278 Review-Url: https://codereview.chromium.org/2478163002 Cr-Commit-Position: refs/heads/master@{#430258} [modify] https://crrev.com/cce92f9630364bbab9c37478ae7b24f25cf3ffa1/chrome/browser/prerender/prerender_browsertest.cc
,
Nov 7 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 28 2016