New issue
Advanced search Search tips

Issue 660278 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

PrerenderBrowserTest.AutosigninInPrerenderer has been flaky

Project Member Reported by tyoshino@chromium.org, Oct 28 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42b5e1d1eeea0b30d8332a919596ff39eae676d3

commit 42b5e1d1eeea0b30d8332a919596ff39eae676d3
Author: tyoshino <tyoshino@chromium.org>
Date: Fri Oct 28 05:06:00 2016

Disable flaky test PrerenderBrowserTest.AutosigninInPrerenderer

BUG= 660278 
R=yhirano@chromium.org
TBR=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2460453003
Cr-Commit-Position: refs/heads/master@{#428289}

[modify] https://crrev.com/42b5e1d1eeea0b30d8332a919596ff39eae676d3/chrome/browser/prerender/prerender_browsertest.cc

Status: Started (was: Assigned)
Confirmed. The problem is that the prerender may fully load or be interrupted before. It doesn't matter for the test logic. However, it was checked by default.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44655c02fec42900c8379e49bb83fa8e8b9629ff

commit 44655c02fec42900c8379e49bb83fa8e8b9629ff
Author: vasilii <vasilii@chromium.org>
Date: Fri Oct 28 15:12:54 2016

Fix PrerenderBrowserTest.AutosigninInPrerenderer flakiness.

The test checked that the prerender is stopped before the page is fully loaded. It's not guaranteed and its unrelated to the test logic.

BUG= 660278 

Review-Url: https://codereview.chromium.org/2458953002
Cr-Commit-Position: refs/heads/master@{#428374}

[modify] https://crrev.com/44655c02fec42900c8379e49bb83fa8e8b9629ff/chrome/browser/prerender/prerender_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cce92f9630364bbab9c37478ae7b24f25cf3ffa1

commit cce92f9630364bbab9c37478ae7b24f25cf3ffa1
Author: vasilii <vasilii@chromium.org>
Date: Mon Nov 07 13:02:57 2016

Fix potential flakiness in PrerenderBrowserTest.AutosigninInPrerenderer

This is a follow-up to https://codereview.chromium.org/2458953002.

BUG= 660278 

Review-Url: https://codereview.chromium.org/2478163002
Cr-Commit-Position: refs/heads/master@{#430258}

[modify] https://crrev.com/cce92f9630364bbab9c37478ae7b24f25cf3ffa1/chrome/browser/prerender/prerender_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment