New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660271 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Bug 654100 breaks testbeds

Project Member Reported by krisr@chromium.org, Oct 28 2016

Issue description

After 654100, when I run:

$ atest host create android1758-test-station-29 -b os:android -i "serials=84B7N15A28011401,84B7N15A28012422,84B7N15A28012436"

I get:
Operation host_add_labels failed:
    ValidationError: {'labels': u'Adding more than one platform/board label:  board:angler-1, board:angler-2, board:angler-3'}

This breaks adding test beds, and since we had to remove and re-add some devices we have down test stations.
 

Comment 1 by krisr@chromium.org, Oct 28 2016

I can create an adb device.  If there is a way I can create an adb device and hack in the other labels and change the platform after the fact as a work around for now that is fine.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4a3deb8609497ce4812584728d5289e34759fe72

commit 4a3deb8609497ce4812584728d5289e34759fe72
Author: Dan Shi <dshi@google.com>
Date: Fri Oct 28 04:32:30 2016

[autotest] Allow atest host create to add multiple board label for testbed

testbed may have multiple board labels, e.g.,
board:angler-1, board:angler-2, board:angler-3

autotest code was changed earlier to prevent a dut to have multiple board
labels, which may corrupt shard database.
This change allows testbed to be able to add multiple board labels.

BUG= chromium:660271 
TEST=local add testbed, unittest

Change-Id: I198cafef999c7064e6459985402e3248a57470b5
Reviewed-on: https://chromium-review.googlesource.com/404535
Tested-by: Dan Shi <dshi@google.com>
Reviewed-by: Kris Rambish <krisr@chromium.org>
Commit-Queue: Dan Shi <dshi@google.com>

[modify] https://crrev.com/4a3deb8609497ce4812584728d5289e34759fe72/frontend/afe/rpc_interface_unittest.py
[modify] https://crrev.com/4a3deb8609497ce4812584728d5289e34759fe72/frontend/afe/rpc_interface.py

Owner: dshi@chromium.org
Kevin, Kris and I are still hitting this.  There may be a bug in the change.
The change assumes all the board labels will be the same board type (angler-1, angler-2, ...) but if they're different (angler-1, shamu-1, ...) then we still get rejected which blocks creation of testbeds with multiple devices.

The change just want to be more relaxed and allow all board labels of the type .*-/d+
example test station: android1758-row3-rack5-aj has {'labels': u'Adding more than one platform/board label:  board:shamu-1, board:angler-1, board:bullhead-1, board:marlin-1'}
Any updates on a resolution for this?

Comment 7 by dshi@chromium.org, Nov 4 2016

The fix should have been pushed to lab, give it a try?

Comment 8 by dshi@chromium.org, Nov 4 2016

wait, cl is still pending review:
https://chromium-review.googlesource.com/#/c/407068/
Components: -Infra>Labs -Infra>Labs>HWOps
krisr@: please do not set these components on requests like this in the future.  They are for chrome-browser labs only.
**friendly ping**

This is a P0 and the CL has been pending for a couple days now.
I was previously able to add test stations to autotest with devices of all the same platform. I'm no longer able to do that. Autotest will create the testbed but will not populate the devices.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b5b8b4f981036971c619b26956c8847140eabd35

commit b5b8b4f981036971c619b26956c8847140eabd35
Author: Dan Shi <dshi@google.com>
Date: Wed Nov 02 21:04:02 2016

[autotest] Loosens board list check when adding new board labels.

testbed may have a mix of different boards. This change loosens the board list
check to allow any board labels ending with -number to be added to a host.

BUG= chromium:660271 
TEST=unittest

Change-Id: If5f8487472f1092b5ebc24e3df90c7965aa382d0
Reviewed-on: https://chromium-review.googlesource.com/407068
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Dan Shi <dshi@google.com>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/b5b8b4f981036971c619b26956c8847140eabd35/server/site_utils_unittest.py
[modify] https://crrev.com/b5b8b4f981036971c619b26956c8847140eabd35/frontend/afe/models_test.py
[modify] https://crrev.com/b5b8b4f981036971c619b26956c8847140eabd35/frontend/afe/rpc_interface_unittest.py
[modify] https://crrev.com/b5b8b4f981036971c619b26956c8847140eabd35/frontend/afe/models.py
[modify] https://crrev.com/b5b8b4f981036971c619b26956c8847140eabd35/server/site_utils.py
[modify] https://crrev.com/b5b8b4f981036971c619b26956c8847140eabd35/frontend/afe/rpc_interface.py

Still not able to add multiple boards. Any updates regarding this?
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 30 2016

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 15 by dshi@chromium.org, Nov 30 2016

Sorry, I lost track of this bug.

jashur, can you show me the command line and output when you try to create a testbed with multiple boards?
Project Member

Comment 16 by sheriffbot@chromium.org, Dec 15 2016

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by dshi@chromium.org, Feb 6 2017

Owner: jashur@chromium.org
 jashur, please see comment #15
Hi Dan, I apologize for the late response, I was away in Chicago on a two week trip at the time for the holidays and may have overlooked this message. As far as i know this has been resolved but I'm not sure exactly what the fix was to make it work. At the moment we don't have any stations that require multiple platforms to be added to the same station, so I cannot paste an output at this exact moment. Once we do, I can update this ticket.

As a confirmation that this may have been resolved, below is one of the entries from an autotest testbed with multiple platforms:

android1758-row3-rack2-test-station-2	testbed	board:razor-1, os:android, camera-hal, board:hammerhead-1, loopback-dongle, board:bullhead-1, androidwificell	Ready	No

Comment 19 by dshi@chromium.org, Feb 6 2017

Labels: -Pri-0 Pri-2
Status: Fixed (was: Assigned)
OK, I will mark this as fixed for now. If you run into similar issue, please re-open this.

Sign in to add a comment