New issue
Advanced search Search tips

Issue 660262 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in v8::internal::wasm::ThreadImpl::DoBreak

Project Member Reported by ClusterFuzz, Oct 28 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4733719077453824

Fuzzer: afl_v8_wasm_code_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x6250000183f0
Crash State:
  v8::internal::wasm::ThreadImpl::DoBreak
  v8::internal::wasm::ThreadImpl::Execute
  v8::internal::wasm::ThreadImpl::Run
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=afl_chrome_asan&range=427847:428110

Minimized Testcase (0.03 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97vBiHY8ZndlXYZOz_6PG6QzaqETJ4dyKGDrKASg8WDohL-E7jRIHpX_PhuSqVV8pVuydpFF8WR1BvSEckSdvHah9zoFUk-DZ-aNeUK5NbOvVq8eH8aOCkjxgpvWyrUA4IFU7FZ__aIxCr4U1zQ2t1x_3VZjg?testcase_id=4733719077453824

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by aarya@google.com, Oct 28 2016

Components: Blink>JavaScript
Owner: ahaas@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 28 2016

Labels: M-56
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 28 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 28 2016

Labels: Pri-1
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a3b77d560e245ee04cdc254e033ff29e55a7cf86

commit a3b77d560e245ee04cdc254e033ff29e55a7cf86
Author: ahaas <ahaas@chromium.org>
Date: Wed Nov 02 17:06:38 2016

[wasm] Fix br_table in the wasm interpreter to use varuint32.

The wasm interpreter crashed because it interpreted the table of
br_table as a table of uint8, but according to the spec it is a table of
varint32. Therefore the wasm interpreter misinterpreted 0x80 0x00 as 128
and not as 0, which caused a crash.

R=tizer@chromium.org
BUG= chromium:660262 
TEST=cctest/test-run-wasm/RunWasmInterpreted_Regression_660262

Review-Url: https://codereview.chromium.org/2463063002
Cr-Commit-Position: refs/heads/master@{#40708}

[modify] https://crrev.com/a3b77d560e245ee04cdc254e033ff29e55a7cf86/src/wasm/wasm-interpreter.cc
[modify] https://crrev.com/a3b77d560e245ee04cdc254e033ff29e55a7cf86/test/cctest/wasm/test-run-wasm.cc

Project Member

Comment 6 by ClusterFuzz, Nov 4 2016

ClusterFuzz has detected this issue as fixed in range 429549:429574.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4733719077453824

Fuzzer: afl_v8_wasm_code_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x6250000183f0
Crash State:
  v8::internal::wasm::ThreadImpl::DoBreak
  v8::internal::wasm::ThreadImpl::Execute
  v8::internal::wasm::ThreadImpl::Run
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=afl_chrome_asan&range=427847:428110
Fixed: https://cluster-fuzz.appspot.com/revisions?job=afl_chrome_asan&range=429549:429574

Minimized Testcase (0.03 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97vBiHY8ZndlXYZOz_6PG6QzaqETJ4dyKGDrKASg8WDohL-E7jRIHpX_PhuSqVV8pVuydpFF8WR1BvSEckSdvHah9zoFUk-DZ-aNeUK5NbOvVq8eH8aOCkjxgpvWyrUA4IFU7FZ__aIxCr4U1zQ2t1x_3VZjg?testcase_id=4733719077453824

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 4 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 5 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 9 by awhalley@google.com, Dec 15 2016

Labels: -ReleaseBlock-Beta
Project Member

Comment 10 by sheriffbot@chromium.org, Feb 10 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment