New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660261 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 660258



Sign in to add a comment

TPM 2.0: Add a way to test Chrome OS against the Google test PCA and not the production one

Project Member Reported by drcrash@chromium.org, Oct 28 2016

Issue description

Subset of crbug/660258 which affects:

- attestationd
- cryptohome
- chromium

 

 
Cc: apronin@chromium.org
Owner: drcrash@chromium.org
Status: Assigned (was: Untriaged)
Cc: dkalin@chromium.org
See https://bugs.chromium.org/p/chromium/issues/detail?id=660260 for TPM 1.2 solution for reference.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/tpm/+/f6754353a770936c20c6dd80b8c9f94e2f72048e

commit f6754353a770936c20c6dd80b8c9f94e2f72048e
Author: Yves Arrouye <drcrash@google.com>
Date: Thu Oct 12 01:32:44 2017

Support the test ACA through the service API rather than compile ifdef

Introduce an ACAType to select between the default (production) and
test ACA and add it to messages where the type of ACA makes a
difference.

Also replace the unused alternate ACA credentials with test ones.

BUG= chromium:660261 
TEST=unit_tests

Change-Id: Ie7e164ceaa3b8b99397de598b4f05f2b92b38df9
Reviewed-on: https://chromium-review.googlesource.com/678854
Commit-Ready: Yves Arrouye <drcrash@chromium.org>
Tested-by: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/f6754353a770936c20c6dd80b8c9f94e2f72048e/attestation/common/interface.proto
[modify] https://crrev.com/f6754353a770936c20c6dd80b8c9f94e2f72048e/attestation/server/attestation_service.cc
[modify] https://crrev.com/f6754353a770936c20c6dd80b8c9f94e2f72048e/attestation/server/attestation_service_test.cc
[modify] https://crrev.com/f6754353a770936c20c6dd80b8c9f94e2f72048e/attestation/server/attestation_service.h
[modify] https://crrev.com/f6754353a770936c20c6dd80b8c9f94e2f72048e/attestation/common/database.proto

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d853d59f0b920429e97eb761c8fa47c6b72f8793

commit d853d59f0b920429e97eb761c8fa47c6b72f8793
Author: Yves Arrouye <drcrash@google.com>
Date: Thu Oct 12 01:32:44 2017

cryptohome: Support the test ACA in ServiceDistributed

Convert PCA type to ACA type as needed and pass the ACA type to
the attestationd service in order to be able to select between the
default and the test ACA.

BUG= chromium:660261 
TEST=unit_tests
CQ-DEPEND=CL:678854

Change-Id: Ieb3590c6f484fe4d9f0a1f4dab476e9ae098e39c
Reviewed-on: https://chromium-review.googlesource.com/678855
Commit-Ready: Yves Arrouye <drcrash@chromium.org>
Tested-by: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/d853d59f0b920429e97eb761c8fa47c6b72f8793/cryptohome/service_distributed.cc
[modify] https://crrev.com/d853d59f0b920429e97eb761c8fa47c6b72f8793/cryptohome/service_distributed.h

Status: Fixed (was: Assigned)

Sign in to add a comment