New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660239 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Team-Security-UX

Blocking:
issue 650420



Sign in to add a comment

Permission icons in Page Info should not have "image" accessibility label.

Project Member Reported by lgar...@chromium.org, Oct 28 2016

Issue description

The label should be blank so that VoiceOver skips it. Instead, it defaults to "image".

Happens for both native Mac and MacViews.
Not sure about Views.
 
Labels: -M-55 M-56
Summary: Permission icons in Page Info should not have "image" accessibility label. (was: Mac/MacViews: permission icons in Page Info should not have "image" accessibility label.)
This issue is present in:
- Native Mac
- Views on Windows

Not present on:
- Chrome OS

I tried to use the screen reader on Linux, but gave up for now.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8160f6a36c45ec4fc0cdfb9d47ebffcb2bafa69

commit b8160f6a36c45ec4fc0cdfb9d47ebffcb2bafa69
Author: lgarron <lgarron@chromium.org>
Date: Wed Nov 09 23:05:15 2016

Page Info (native Mac): remove images from accessibility order

Images are accompanied by descriptive text, so it is unnecessary for them to be int he accessibility order. (Currently, they are also read as "image", which is not useful.)

BUG= 660239 

Review-Url: https://codereview.chromium.org/2478733002
Cr-Commit-Position: refs/heads/master@{#431068}

[modify] https://crrev.com/b8160f6a36c45ec4fc0cdfb9d47ebffcb2bafa69/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Labels: Needs-Feedback
lgarron@ : Could you please let us know the steps involved to verify from TE end with the supportive urls and flags.
I just realized this also happens for the permission images in permission bubbles.
Labels: Merge-Request-55
Requesting a merge of b8160f6a36c45ec4fc0cdfb9d47ebffcb2bafa69 to M55.

Comment 6 by dimu@chromium.org, Nov 11 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 7 Deleted

[Sorry, correction to #7: #mac-views-webui-dialogs is the relevant flag.]

durga.behera@:

Mac:
1) Make sure #mac-views-webui-dialogs is DISABLED in chrome://flags
2) Enable VoiceOver (Cmd-F5 by default)
3) Visit google.com and click on the lock icon to open the Page Info bubble.
4) Use Ctrl-Opt-(right arrow) to navigate the Page Info bubble. Text, buttons, and links should be read, but the images next to "Cookies" and the various permission should nod.

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 12 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cd5ca2da5cbdd02c741851fc1f47832cf986287

commit 3cd5ca2da5cbdd02c741851fc1f47832cf986287
Author: Lucas Garron <lgarron@chromium.org>
Date: Sat Nov 12 00:21:47 2016

Page Info (native Mac): remove images from accessibility order

Images are accompanied by descriptive text, so it is unnecessary for them to be in the accessibility order. (Currently, they are also read as "image", which is not useful.)

BUG= 660239 

Review-Url: https://codereview.chromium.org/2478733002
Cr-Commit-Position: refs/heads/master@{#431068}
(cherry picked from commit b8160f6a36c45ec4fc0cdfb9d47ebffcb2bafa69)

Review URL: https://codereview.chromium.org/2492013006 .

Cr-Commit-Position: refs/branch-heads/2883@{#553}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/3cd5ca2da5cbdd02c741851fc1f47832cf986287/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Laura, it seems not even Apple actually hides images like this from accessibility?

I just got a calendar reminder native OS notification. The image was selected and VoiceOver read "Image. You can currently on an image." Do you consider this a bug in OSX, or is it possible that we should actually make it clear when/where there are images in the UI?
Screen Shot 2016-11-11 at 16.50.12.png
29.3 KB View Download
Screen Shot 2016-11-11 at 16.54.38 1.png
146 KB View Download
See  Issue 664697  for the permission bubble version of this bug.

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b1f577315991631d7e9d02d514d7e5042862e28

commit 2b1f577315991631d7e9d02d514d7e5042862e28
Author: lgarron <lgarron@chromium.org>
Date: Tue Nov 15 05:57:47 2016

Page Info (Views): remove images from accessibility order

Images are accompanied by descriptive text, so it is unnecessary for them to be in the accessibility order. (Currently, they are also read as "image", which is not useful.)

BUG= 660239 
TEST=Two platforms:
Mac:
1) Enable #mac-views-webui-dialogs in chrome://flags
2) Enable VoiceOver (Cmd-F5 by default)
3) Visit google.com and click on the lock icon to open the Page Info bubble.
4) Use Ctrl-Opt-(right arrow) to navigate the Page Info bubble. Text, buttons, and links should be read, but the images next to "Cookies" and the various permission should not.
Windows:
1) Enable Microsoft Narrator.
2) Visit google.com and click on the lock icon to open the Page Info bubble.
3) Navigate the Page Info bubble [1]. Text, buttons, and links should be read, but the images next to "Cookies" and the various permission should not.

[1] https://support.microsoft.com/en-us/help/14234/windows-hear-text-read-aloud-with-narrator

Review-Url: https://codereview.chromium.org/2491773002
Cr-Commit-Position: refs/heads/master@{#432122}

[modify] https://crrev.com/2b1f577315991631d7e9d02d514d7e5042862e28/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/2b1f577315991631d7e9d02d514d7e5042862e28/chrome/browser/ui/views/website_settings/non_accessible_image_view.cc
[add] https://crrev.com/2b1f577315991631d7e9d02d514d7e5042862e28/chrome/browser/ui/views/website_settings/non_accessible_image_view.h
[modify] https://crrev.com/2b1f577315991631d7e9d02d514d7e5042862e28/chrome/browser/ui/views/website_settings/permission_selector_row.cc
[modify] https://crrev.com/2b1f577315991631d7e9d02d514d7e5042862e28/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Labels: Needs-Feedback
Verified the issue on Mac 10.11.6 and Win 10 using 55.0.2883.52, its not working on Mac as still the Voice over reads image next to the cookies,camera icons.
Its working fine on Win 10 as the Narrator does not navigate to Cookies,Camera etc and images next to it(the recording is poor on win 10 as it require a Screencast pro to record the Device Audio).

lgarron@ : Could you please take a look into this an update if any missed here.
Win 10.mp4
1.7 MB View Download
660239_Nov_16.mp4
1.2 MB View Download
2b1f577315991631d7e9d02d514d7e5042862e28 has not been merged to 55 (because it has not yet baked in Canary).

On Windows, it seems you're using tab to navigate. If you use the Narrator shortcuts (e.g. Caps lock + right arrow), it should still go through images.

I'll ask for a merge to 55 as soon as it's baked on Canary.
Cc: ranjitkan@chromium.org
Labels: -Needs-Feedback TE-Verified-M56 TE-Verified-56.0.2923.0 TE-Verified-56.0.2922.0
Rechecked this issue on chrome canary version 56.0.2923.0 on MAC 10.12.1 by enabling Voice over and it does not read the image icons displayed adjacent to cookies,camera, location.

Also verified on chrome version 56.0.2922.0 on Windows 10 using Narrator (Shortcut: Caps lock + Right Arrow) and in this case as well image icons displayed adjacent to cookies,camera, location are not read. 

This is working as intended as per steps in comment#12 and 14. Adding TE-Verified labels.

Thanks.!
Status: Fixed (was: Assigned)
I believe we're done.

There's a general Page Info accessibility followup bug:  Issue 660243 .

Sign in to add a comment