New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660238 link

Starred by 0 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[REGRESSION] DevTools: dirty file asterisk is not shown in Workspace

Project Member Reported by lushnikov@chromium.org, Oct 28 2016 
What steps will reproduce the problem?
(1) Establish workspace
(2) Try to edit a filesystem file which is linked to network
(3) Notice that "*" doesn't appear in the tab title.

What is the expected output?
The "*" appears.

What do you see instead?
It doesn't.


This was regressed by crrev.com/2384783003, fix has to be merged to M-55.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfa81c19d0c430c2df363f6f9685031cddb21785

commit bfa81c19d0c430c2df363f6f9685031cddb21785
Author: lushnikov <lushnikov@chromium.org>
Date: Fri Oct 28 03:30:27 2016

DevTools: [Workspace] show dirty asterisk in file tab title.

As we don't sync working copies between uiSourceCodes of persistent
binding (for now), we should get the dirty state of the original uiSourceCode
in the TabbedEditorContainer._titleForTab method.

BUG= 660238 
R=dgozman

Review-Url: https://codereview.chromium.org/2462493002
Cr-Commit-Position: refs/heads/master@{#428271}

[modify] https://crrev.com/bfa81c19d0c430c2df363f6f9685031cddb21785/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Comment 2 by lushnikov@chromium.org, Oct 28 2016

Status: Started (was: Assigned)

Comment 3 by lushnikov@chromium.org, Oct 31 2016

Labels: -lusha-merge-tbd Merge-Request-55
Works as expected on Mac Chrome Canary 56.0.2905.0
Would be nice to have this in M-55.

Comment 4 by dimu@chromium.org, Oct 31 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/490721373725233a324418258002a4f702266d1c

commit 490721373725233a324418258002a4f702266d1c
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Oct 31 19:40:16 2016

DevTools: [Workspace] show dirty asterisk in file tab title.

As we don't sync working copies between uiSourceCodes of persistent
binding (for now), we should get the dirty state of the original uiSourceCode
in the TabbedEditorContainer._titleForTab method.

BUG= 660238 
R=dgozman

Review-Url: https://codereview.chromium.org/2462493002
Cr-Commit-Position: refs/heads/master@{#428271}
(cherry picked from commit bfa81c19d0c430c2df363f6f9685031cddb21785)

Review URL: https://codereview.chromium.org/2466013002 .

Cr-Commit-Position: refs/branch-heads/2883@{#390}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/490721373725233a324418258002a4f702266d1c/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Comment 6 by lushnikov@chromium.org, Oct 31 2016

Status: Fixed (was: Started)
►

Sign in to add a comment