New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660237 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.banners.AppBannerManagerTest#testWebAppSplashscreenIsDownloaded" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Oct 28 2016

Issue description

"org.chromium.chrome.browser.banners.AppBannerManagerTest#testWebAppSplashscreenIsDownloaded" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZgsSBUZsYWtlIltvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuYmFubmVycy5BcHBCYW5uZXJNYW5hZ2VyVGVzdCN0ZXN0V2ViQXBwU3BsYXNoc2NyZWVuSXNEb3dubG9hZGVkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Example failure:
org.chromium.chrome.browser.banners.AppBannerManagerTest#testWebAppSplashscreenIsDownloaded (run #1):
junit.framework.AssertionFailedError: Criteria not met in allotted time.
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:112)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:133)
	at org.chromium.chrome.browser.banners.AppBannerManagerTest.testWebAppSplashscreenIsDownloaded(AppBannerManagerTest.java:530)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Doesn't look like it's because of change to the test; the only recent modification on the 25th is https://chromium.googlesource.com/chromium/src/+/b0ea59bf0f96b9cb8d43509b531726a1e65dda91. I'm going to assume there's either a race in the test or that some wait time is too short.
Cc: dominickn@chromium.org
Owner: dfalcant...@chromium.org
Status: Assigned (was: Untriaged)
Assigning dfalcantara as per OWNERS file for the test.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/329928769e9fdcb0cdd1766adcdc39130fe6fc57

commit 329928769e9fdcb0cdd1766adcdc39130fe6fc57
Author: phoglund <phoglund@chromium.org>
Date: Fri Oct 28 11:04:35 2016

Disable flaky testWebAppSplashscreenIsDownloaded test.

I commented out @SmallTest etc since almost all instances of
DisabledTest in code search also commented SmallTest out. That doesn't
make any sense to me though; surely commenting out cannot be necessary
unless DisabledTest has no effect at all on the test runner?

BUG= 660237 
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2458963002
Cr-Commit-Position: refs/heads/master@{#428331}

[modify] https://crrev.com/329928769e9fdcb0cdd1766adcdc39130fe6fc57/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Labels: -Sheriff-Chromium
Cc: -dominickn@chromium.org dfalcant...@chromium.org
Owner: dominickn@chromium.org
Dominick: is this related to whatever you were doing here?
Cc: dominickn@chromium.org
Owner: phoglund@chromium.org
There are a whole bunch of infobar tests which seem to have just become flaky. I haven't touched this code for a few weeks now so it shouldn't have become flaky because of something I did.

Back to phoglund: was the revert of crrev.com/2362033002 the fix?
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/774704ae97973e1f9cde57e2a9c7818a8d3b5196

commit 774704ae97973e1f9cde57e2a9c7818a8d3b5196
Author: dominickn <dominickn@chromium.org>
Date: Sun Oct 30 23:20:57 2016

Revert of Disable flaky testWebAppSplashscreenIsDownloaded test. (patchset #1 id:1 of https://codereview.chromium.org/2458963002/ )

Reason for revert:
The offending CL that caused the failures has been reverted (crrev.com/2362033002)

Original issue's description:
> Disable flaky testWebAppSplashscreenIsDownloaded test.
>
> I commented out @SmallTest etc since almost all instances of
> DisabledTest in code search also commented SmallTest out. That doesn't
> make any sense to me though; surely commenting out cannot be necessary
> unless DisabledTest has no effect at all on the test runner?
>
> BUG= 660237 
> TBR=dfalcantara@chromium.org
>
> Committed: https://crrev.com/329928769e9fdcb0cdd1766adcdc39130fe6fc57
> Cr-Commit-Position: refs/heads/master@{#428331}

TBR=dfalcantara@chromium.org,phoglund@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 660237 

Review-Url: https://codereview.chromium.org/2461273002
Cr-Commit-Position: refs/heads/master@{#428635}

[modify] https://crrev.com/774704ae97973e1f9cde57e2a9c7818a8d3b5196/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Status: Fixed (was: Assigned)
Oh, I didn't realize your test was infobar related. Yeah, that probably fixed it then.

Sign in to add a comment