"org.chromium.chrome.browser.banners.AppBannerManagerTest#testWebAppSplashscreenIsDownloaded" is flaky |
||||||
Issue description"org.chromium.chrome.browser.banners.AppBannerManagerTest#testWebAppSplashscreenIsDownloaded" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZgsSBUZsYWtlIltvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuYmFubmVycy5BcHBCYW5uZXJNYW5hZ2VyVGVzdCN0ZXN0V2ViQXBwU3BsYXNoc2NyZWVuSXNEb3dubG9hZGVkDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Oct 28 2016
Assigning dfalcantara as per OWNERS file for the test.
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/329928769e9fdcb0cdd1766adcdc39130fe6fc57 commit 329928769e9fdcb0cdd1766adcdc39130fe6fc57 Author: phoglund <phoglund@chromium.org> Date: Fri Oct 28 11:04:35 2016 Disable flaky testWebAppSplashscreenIsDownloaded test. I commented out @SmallTest etc since almost all instances of DisabledTest in code search also commented SmallTest out. That doesn't make any sense to me though; surely commenting out cannot be necessary unless DisabledTest has no effect at all on the test runner? BUG= 660237 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2458963002 Cr-Commit-Position: refs/heads/master@{#428331} [modify] https://crrev.com/329928769e9fdcb0cdd1766adcdc39130fe6fc57/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
,
Oct 28 2016
,
Oct 28 2016
Dominick: is this related to whatever you were doing here?
,
Oct 30 2016
There are a whole bunch of infobar tests which seem to have just become flaky. I haven't touched this code for a few weeks now so it shouldn't have become flaky because of something I did. Back to phoglund: was the revert of crrev.com/2362033002 the fix?
,
Oct 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/774704ae97973e1f9cde57e2a9c7818a8d3b5196 commit 774704ae97973e1f9cde57e2a9c7818a8d3b5196 Author: dominickn <dominickn@chromium.org> Date: Sun Oct 30 23:20:57 2016 Revert of Disable flaky testWebAppSplashscreenIsDownloaded test. (patchset #1 id:1 of https://codereview.chromium.org/2458963002/ ) Reason for revert: The offending CL that caused the failures has been reverted (crrev.com/2362033002) Original issue's description: > Disable flaky testWebAppSplashscreenIsDownloaded test. > > I commented out @SmallTest etc since almost all instances of > DisabledTest in code search also commented SmallTest out. That doesn't > make any sense to me though; surely commenting out cannot be necessary > unless DisabledTest has no effect at all on the test runner? > > BUG= 660237 > TBR=dfalcantara@chromium.org > > Committed: https://crrev.com/329928769e9fdcb0cdd1766adcdc39130fe6fc57 > Cr-Commit-Position: refs/heads/master@{#428331} TBR=dfalcantara@chromium.org,phoglund@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 660237 Review-Url: https://codereview.chromium.org/2461273002 Cr-Commit-Position: refs/heads/master@{#428635} [modify] https://crrev.com/774704ae97973e1f9cde57e2a9c7818a8d3b5196/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
,
Oct 31 2016
Oh, I didn't realize your test was infobar related. Yeah, that probably fixed it then. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by phoglund@chromium.org
, Oct 28 2016