New issue
Advanced search Search tips

Issue 660234 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

In Port, enforce that baseline directory names are port names.

Project Member Reported by qyears...@chromium.org, Oct 28 2016 
Right now the baseline directory names are always either port names ("linux", "mac", ...) or "full port names" (port name + "-" + version).

Maybe it would make sense to assert that somewhere.

Context: https://codereview.chromium.org/2456073002/

Comment 1 by qyears...@chromium.org, Apr 6 2017

Labels: Hotlist-GoodFirstBug
This could probably just be an assert added in the Port constructor at https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py?l=151.

Specifically, the names in FALLBACK_PATHS should be strings in SUPPORTED_VERSIONS or should be equal to the port_name.

The advantage of doing this would just be to guard against adding new baseline directory names that don't follow the current convention.

Comment 2 by qyears...@chromium.org, Apr 14 2017 

Relatedly, we could also assert that full port names have a consistent format (always <os>-<version>).
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by qyears...@chromium.org, Apr 16 2018

Status: WontFix (was: Untriaged)
Not really very important.
►

Sign in to add a comment