SSL.MarkHttpAs histogram records the wrong value when passwords/cc flag is set |
|||
Issue descriptionhttps://cs.chromium.org/chromium/src/components/security_state/security_state_model.cc?q=security_state_model.cc&sq=package:chromium&l=52 SSL.MarkHttpAs records a histogram value of NEUTRAL when the switch is set to switches::kMarkHttpWithPasswordsOrCcWithChip and a password/cc field is not displayed. This should be HTTP_SHOW_WARNING, because the histogram is supposed to record the flag value, not the security level.
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4c0ef66fbec87aef17d8d24036a9465251d3ae8 commit c4c0ef66fbec87aef17d8d24036a9465251d3ae8 Author: elawrence <elawrence@chromium.org> Date: Fri Oct 28 15:39:40 2016 Log SSL.MarkHttpAs histogram without regard to state of the page The SSL.MarkHTTPAs histogram should record the state of the switch or field trial group regardless of whether or not the current page has a non-secure password field. BUG= 660226 Review-Url: https://codereview.chromium.org/2459883002 Cr-Commit-Position: refs/heads/master@{#428382} [modify] https://crrev.com/c4c0ef66fbec87aef17d8d24036a9465251d3ae8/components/security_state/security_state_model.cc [modify] https://crrev.com/c4c0ef66fbec87aef17d8d24036a9465251d3ae8/components/security_state/security_state_model_unittest.cc
,
Oct 28 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
|||
►
Sign in to add a comment |
|||
Comment 1 by elawrence@chromium.org
, Oct 28 2016Owner: elawrence@chromium.org
Status: Started (was: Available)