New issue
Advanced search Search tips

Issue 660210 link

Starred by 1 user
Status: Fixed
Owner:
tmartino@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 248883



Sign in to add a comment

Finalize Launch Flow Refactor including Session Restore logic

Project Member Reported by tmartino@chromium.org, Oct 27 2016 
This bug tracks the remaining efforts on the refactor, including:
- Disabling the flow on Win 10, which has been descoped for M55
- Reintroducing session restore logic
- Correcting a number of bugs uncovered by restore, including:
    - Issues with Guest mode
    - NTP incorrectly added to restored sessions
    - Pinned tabs added in duplicate to restored sessions
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43f9c50bcb8b440c0f462b69f13b4bf9994e639b

commit 43f9c50bcb8b440c0f462b69f13b4bf9994e639b
Author: tmartino <tmartino@chromium.org>
Date: Wed Nov 02 16:38:55 2016

Completing refactor of startup_browser_creator_impl. This includes:

- Reintroducing session restore logic.

- Preventing Win 10 from branching on this codepath, as Win10 has been descoped from this launch.

- Correcting several small but critical bugs surfaced by session restore path:
  - Unexpected content in Guest Mode.
  - NTP showing unexpectedly on restored sessions.
  - Pinned tabs appearing duplicated on restored sessions.

BUG= 660210 

Review-Url: https://codereview.chromium.org/2457653003
Cr-Commit-Position: refs/heads/master@{#429303}

[modify] https://crrev.com/43f9c50bcb8b440c0f462b69f13b4bf9994e639b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/43f9c50bcb8b440c0f462b69f13b4bf9994e639b/chrome/browser/ui/startup/startup_browser_creator_impl.h
[modify] https://crrev.com/43f9c50bcb8b440c0f462b69f13b4bf9994e639b/chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc
[modify] https://crrev.com/43f9c50bcb8b440c0f462b69f13b4bf9994e639b/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/43f9c50bcb8b440c0f462b69f13b4bf9994e639b/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/43f9c50bcb8b440c0f462b69f13b4bf9994e639b/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
[modify] https://crrev.com/43f9c50bcb8b440c0f462b69f13b4bf9994e639b/chrome/common/chrome_switches.cc

Comment 2 by tmartino@chromium.org, Nov 2 2016

Status: Fixed (was: Started)

Comment 3 by tmartino@chromium.org, Nov 11 2016

Labels: Merge-Request-55
Verified in Canary

Comment 4 by dimu@chromium.org, Nov 11 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 11 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a36593373bb029876ec7bcf2e51ae61786bdbb2c

commit a36593373bb029876ec7bcf2e51ae61786bdbb2c
Author: mahmadi <mahmadi@chromium.org>
Date: Fri Nov 11 23:11:48 2016

Completing refactor of startup_browser_creator_impl. This includes:

- Reintroducing session restore logic.

- Preventing Win 10 from branching on this codepath, as Win10 has been descoped from this launch.

- Correcting several small but critical bugs surfaced by session restore path:
  - Unexpected content in Guest Mode.
  - NTP showing unexpectedly on restored sessions.
  - Pinned tabs appearing duplicated on restored sessions.

BUG= 660210 

Review-Url: https://codereview.chromium.org/2457653003
Cr-Commit-Position: refs/heads/master@{#429303}
(cherry picked from commit 43f9c50bcb8b440c0f462b69f13b4bf9994e639b)

Review URL: https://codereview.chromium.org/2492963003 .

Cr-Commit-Position: refs/branch-heads/2883@{#550}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/a36593373bb029876ec7bcf2e51ae61786bdbb2c/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/a36593373bb029876ec7bcf2e51ae61786bdbb2c/chrome/browser/ui/startup/startup_browser_creator_impl.h
[modify] https://crrev.com/a36593373bb029876ec7bcf2e51ae61786bdbb2c/chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc
[modify] https://crrev.com/a36593373bb029876ec7bcf2e51ae61786bdbb2c/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/a36593373bb029876ec7bcf2e51ae61786bdbb2c/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/a36593373bb029876ec7bcf2e51ae61786bdbb2c/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
[modify] https://crrev.com/a36593373bb029876ec7bcf2e51ae61786bdbb2c/chrome/common/chrome_switches.cc
►

Sign in to add a comment