New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660207 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
56



Sign in to add a comment

Don't show "select" when dropdown is active for billing address in payment request's card editor.

Project Member Reported by se...@chromium.org, Oct 27 2016

Issue description


^^^
 

Comment 1 by se...@chromium.org, Oct 27 2016

Cc: rouslan@chromium.org zkoch@chromium.org
Here are the current and proposed UI, for your review.
Current.mp4
875 KB View Download
Proposed.mp4
482 KB View Download
Looks good!

Comment 3 by zkoch@chromium.org, Oct 27 2016

Looks good!
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7076c12477de96ee12e819b05e2e559cf8120201

commit 7076c12477de96ee12e819b05e2e559cf8120201
Author: sebsg <sebsg@chromium.org>
Date: Tue Nov 01 16:48:26 2016

[Payments] Don't show select when clicking in billing address drop.

BUG= 660207 

Review-Url: https://codereview.chromium.org/2462473002
Cr-Commit-Position: refs/heads/master@{#429023}

[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
[add] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/HintArrayAdapter.java
[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/java_sources.gni
[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExpiredLocalCardTest.java
[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteServerCardTest.java
[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRemoveBillingAddressTest.java

Comment 5 by se...@chromium.org, Nov 1 2016

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment