Issue metadata
Sign in to add a comment
|
11% regression in blink_perf.dom at 427611:427623 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 27 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8997612672357657152
,
Oct 27 2016
=== Auto-CCing suspected CL author nainar@chromium.org === Hi nainar@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Move Layout Tree Construction code into Element::rebuildLayoutTree() Author : nainar Commit description: This patch uses the two dirty bits (NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree) on Node and adds the relevant getters/setters for them. It makes rebuildLayoutTree() public to be accessed in Document.cpp. It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and uses dirtyBits to call either reattachLayoutTree() on node itself or call rebuildLayoutTree() on children nodes. Also added some comments explaining some design decisions. Will be removed upon completion of separation. BUG= 595137 Committed: https://crrev.com/09b7a8cf0647abca732b3718987a629d12a67fee Review-Url: https://codereview.chromium.org/2398293003 Cr-Original-Commit-Position: refs/heads/master@{#426353} Cr-Commit-Position: refs/heads/master@{#427612} Commit : 651c13992922ce5c2b0dd0072c5c3e4a59a03b87 Date : Wed Oct 26 06:37:39 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@427610 40.1182 0.302511 5 good chromium@427611 39.9267 0.414719 5 good chromium@427612 35.8827 0.256458 5 bad <-- chromium@427614 35.8918 0.254971 5 bad chromium@427617 36.2084 0.233651 5 bad chromium@427623 35.7848 0.237475 5 bad Bisect job ran on: mac_10_10_perf_bisect Bug ID: 660181 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom Test Metric: select-single-remove/select-single-remove Relative Change: 10.80% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2457 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997612672357657152 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5871623209484288 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Oct 28 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by m...@chromium.org
, Oct 27 2016