New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660177 link

Starred by 1 user
Status: Assigned
Owner:
linds...@chromium.org
Cc:
█ yzjr@chromium.org
justincohen@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove EarlGrey wait statements with magic numbers

Project Member Reported by baxley@chromium.org, Oct 27 2016 
Multiple callsites of WaitUntilConditionOrTimeout, pass in a hard-coded value for the timeout. Some are used multiple times, and constants should be used.

Here are a few files that have the issue, along with the values:
form_input_egtest.mm - 10
find_in_page_egtest - 2.0
fullscreen_egtest - 1.0
tab_usage_recorder_egtest - 1.0
translate_egtest - 2.0
bookmarks_egtest - 10
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 30 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by baxley@chromium.org, Nov 2 2017

Components: -Test>iOS Tests
Labels: OS-iOS
Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 5

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by sczs@chromium.org, Nov 7

Cc: -baxley@chromium.org -liaoyuke@chromium.org -huangml@chromium.org justincohen@chromium.org yzjr@chromium.org
Owner: linds...@chromium.org
Status: Assigned (was: Untriaged)
lindsayw@ are you a good owner for this?

Comment 5 by lindsayw@google.com, Nov 7 

Yes thanks
►

Sign in to add a comment