New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660169 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Official build failure due to unused constants.

Project Member Reported by romax@chromium.org, Oct 27 2016

Issue description

Just ran into this when doing an official build locally:

../../chrome/browser/android/offline_pages/request_coordinator_factory.cc:38:12:
error: unused variable 'kPreferUntriedRequest' [-Werror,-Wunused-const-variable]
const bool kPreferUntriedRequest = false;
^

Looks like the constants might need to be wrapped in "#if
!defined(OFFICIAL_BUILD)" as well. I'm not actually sure if any bots will catch
this, I don't think any of the release builders use clang.
 

Comment 1 by romax@chromium.org, Nov 2 2016

Labels: -Pri-0 Pri-2
Status: Fixed (was: Assigned)
https://codereview.chromium.org/2456173002/

has been landed.

Sign in to add a comment