Issue 662945 has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6254f4715b9a55b9dac805d432ce9f33376d65d6

commit 6254f4715b9a55b9dac805d432ce9f33376d65d6
Author: tmartino <tmartino@chromium.org>
Date: Mon Nov 21 01:22:56 2016

Moving new First Run to use per-profile value, rather than simply checking IsChromeFirstRun.

This solves several edge cases described in the bug.

BUG= 660159 

Review-Url: https://codereview.chromium.org/2487553002
Cr-Commit-Position: refs/heads/master@{#433466}

[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/ui/startup/startup_browser_creator.h
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/browser/ui/webui/welcome_ui.cc
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/common/pref_names.cc
[modify] https://crrev.com/6254f4715b9a55b9dac805d432ce9f33376d65d6/chrome/common/pref_names.h

Tried the verification of issues mentioned in C#0 on Linux Ubuntu 14.04 using chrome version(57.0.2929.0) and below are the observations:

1. Does not work on new profiles, if created after first Chrome execution.
> Launched chrome with first run flag(google chrome unstable --profile-directory=5 --enable-features=UseConsolidatedStartupFlow --force-first-run) and does show Welcome page.
> Launched chrome without first run flag(google chrome unstable --profile-directory=6 --enable-features=UseConsolidatedStartupFlow) and in diff profile directory.
> Opens the 'Take Chrome everywhere page' [Earlier this opened NTP as tested on 57.0.2926.0 of Linux Ubuntu 14.04, which doesn't contain the CL from C#3]

2. FRE is never shown if it is blocked from showing on first execution (e.g., if URLs are passed on first run)
>Open a link in Chrome using the command line:google-chrome-unstable www.google.com --profile-directory=5 --enable-features=UseConsolidatedStartupFlow --force-first-run
>Observe that the link (www.google.com) is opened, with no welcome page
>Quit Chrome
>Re-launched Chrome: google-chrome-unstable --profile-directory=5 --enable-features=UseConsolidatedStartupFlow
>Observe the new welcome screen. [Earlier this opened NTP as tested on 57.0.2926.0 of Linux Ubuntu 14.04]

3. May show repeatedly if profile is launched multiple times on same Chrome execution
> Could you please provide the exact verification steps for this.

tmartino@: Please review the above comments and let us know the reproducible steps for verification of 3rd. Will verify this on Mac and Windows-7 accordingly.

Thanks in advance!

Note: Mac canary(>57.0.2926.0) which contains the fix is not available for verification due to Issue 667830 

Thanks ajha@!

Could you actually please refer to the test instructions here: https://docs.google.com/a/google.com/document/d/1Vdi1nRA07FSx2gkDIeTj8Uj2CXuvvhze-Q59uF_0jZg/edit?usp=sharing

Please test all the cases, but specifically focus on:
1) "Creating a new profile within Chrome"
2) "Launching Chrome via a link"
3) Upgrading Chrome with an existing profile

Thanks much!

Also, I don't think we should ever be opening the "Take Chrome everywhere" variant yet...that is only for Win10. Tommy - do you know what's going on there?

Sorry, ignore my previous comment. We expect the "Take Chrome Everywhere" variant on new profile creations. It sounds like your tests for 1. and 2. are working as expected.

Please follow up on the tests in the testing doc. Thanks! :)

Thanks ewald@ for confirming C#4.

Ran all the test cases as per the test instructions doc in C#5 and all the test cases are working as intended as per the testing performed on Windows-7(57.0.2929.0 -32 bit), Mac OS 10.11.6(57.0.2929.4) and Linux Ubuntu 14.04(57.0.2929.0).

Adding the verified label therefore. 

Thanks much! Adding a request to merge back to 56.

Your change meets the bar and is auto-approved for M56 (branch: 2924)

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1070e6a7387b6481179626e497594fb9e50f523e

commit 1070e6a7387b6481179626e497594fb9e50f523e
Author: tmartino <tmartino@chromium.org>
Date: Fri Dec 02 17:44:15 2016

Moving new First Run to use per-profile value, rather than simply checking IsChromeFirstRun.

This solves several edge cases described in the bug.

BUG= 660159 
NOTRY=TRUE
NOPRESUBMIT=TRUE

Review-Url: https://codereview.chromium.org/2487553002
Cr-Commit-Position: refs/heads/master@{#433466}
(cherry picked from commit 6254f4715b9a55b9dac805d432ce9f33376d65d6)

Review-Url: https://codereview.chromium.org/2537773005
Cr-Commit-Position: refs/branch-heads/2924@{#288}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/ui/startup/startup_browser_creator.h
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/browser/ui/webui/welcome_ui.cc
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/common/pref_names.cc
[modify] https://crrev.com/1070e6a7387b6481179626e497594fb9e50f523e/chrome/common/pref_names.h

Tommy, can we mark this as Fixed?