New issue
Advanced search Search tips

Issue 660151 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 659066
Owner: ----
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-1.6% regression in system_health.memory_mobile at 425018:425604

Project Member Reported by m...@chromium.org, Oct 27 2016

Issue description

See the link to graphs below.
 

Comment 1 by m...@chromium.org, Oct 27 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=660151

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_aTbogkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_eaLoAoM


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus9
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 28 2016


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@425313  135988  0.0      5  good
chromium@425386  135988  0.0      5  good
chromium@425423  135988  0.0      4  good
chromium@425441  138420  0.0      5  bad
chromium@425459  138420  0.0      5  bad
chromium@425604  138420  0.0      5  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 660151

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests system_health.memory_mobile
Test Metric: memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/load_media/load_media_flickr
Relative Change: 1.79%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4300
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997615566729051664


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5853450129113088

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 5 by m...@chromium.org, Oct 28 2016

Re-running bisect on test w/ cleaner signal and wider rev range...
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 28 2016

Mergedinto: 659066
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Remove unsafe getFontMetrics methods
Author  : eae
Commit description:
  
Remove the ComputedStyle::getFontMetrics and Font::getFontMetrics helper
methods as they both assume that the primaryFont method always returns a
valid SimpleFontDataObject. That assumption is both incorrect and unsafe
as it can return nullptr in case fallback to the last-resort-font fails.

By replacing the convince calls with explicit calls and null checks that
type of problems becomes more apparent and can be handled appropriately.

R=wkorman@chromium.org
BUG=655815
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2416033003
Cr-Commit-Position: refs/heads/master@{#425437}
Commit  : fdcbab80bc37108f6e03d6906f27831228690350
Date    : Fri Oct 14 19:51:13 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@425001  135988  0.0      5  good
chromium@425236  135988  0.0      5  good
chromium@425353  135988  0.0      5  good
chromium@425412  135988  0.0      5  good
chromium@425427  135988  0.0      5  good
chromium@425434  135988  0.0      5  good
chromium@425436  135988  0.0      5  good
chromium@425437  138420  0.0      5  bad    <--
chromium@425438  138420  0.0      5  bad
chromium@425441  138420  0.0      5  bad
chromium@425470  138420  0.0      5  bad
chromium@425938  138420  0.0      5  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 660151

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.flickr system_health.memory_mobile
Test Metric: memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/load_media/load_media_flickr
Relative Change: 1.79%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4303
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997522261119931216


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5305275131625472

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment