New issue
Advanced search Search tips

Issue 660149 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 660152
Owner: ----
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

memory.top_10_mobile failing on android n5x bot

Project Member Reported by rnep...@chromium.org, Oct 27 2016

Issue description

Summary: memory.top_10_mobile failing on android n5x bot (was: memory.top_10_mobile failing on android n5 bot)
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Oct 27 2016

Mergedinto: 660152
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : android: Don't keep GSA alive if it supports account change broadcasts.
Author  : lizeb
Commit description:
  
Chrome currently connects to a bound service exposed by GSA to get
account change notifications. This elevates GSA's priority for the
system to the foreground level when Chrome is in the foreground,
artificially increasing Chrome's memory footprint. On some phones, the
memory consumption of the GSA process can be above 100MB (PSS), even
though only the account change notifications are required.

Newer versions of GSA send a broadcast intent when the account
changes. This CL listens to the broadcasts, and disonnects from the GSA
service when GSA support the account change broadcast mechanism, freing
the memory for Chrome or other apps on the system.

Note that Chrome still briefly connects to GSA on startup to confirm
that it supports the broadcast. A forthcoming will remove this.

BUG= 614388 

Review-Url: https://codereview.chromium.org/2431223004
Cr-Commit-Position: refs/heads/master@{#427840}
Commit  : e1d19b388fc67f31372a4c2df33e20c0c18dfd97
Date    : Wed Oct 26 22:08:28 2016


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N  Good?
chromium@427833  0          N/A      3  good
chromium@427837  0          N/A      3  good
chromium@427839  0          N/A      3  good
chromium@427840  1          N/A      3  bad    <--
chromium@427846  1          N/A      3  bad
chromium@427858  1          N/A      3  bad
chromium@427883  1          N/A      3  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 660149

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:allocated_by_malloc:peak_size_avg/memory:chrome:all_processes:reported_by_chrome:v8:allocated_by_malloc:peak_size_avg
Relative Change: Zero to non-zero
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/806
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997615761379678656


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5880516207706112

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 27 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : android: Don't keep GSA alive if it supports account change broadcasts.
Author  : lizeb
Commit description:
  
Chrome currently connects to a bound service exposed by GSA to get
account change notifications. This elevates GSA's priority for the
system to the foreground level when Chrome is in the foreground,
artificially increasing Chrome's memory footprint. On some phones, the
memory consumption of the GSA process can be above 100MB (PSS), even
though only the account change notifications are required.

Newer versions of GSA send a broadcast intent when the account
changes. This CL listens to the broadcasts, and disonnects from the GSA
service when GSA support the account change broadcast mechanism, freing
the memory for Chrome or other apps on the system.

Note that Chrome still briefly connects to GSA on startup to confirm
that it supports the broadcast. A forthcoming will remove this.

BUG= 614388 

Review-Url: https://codereview.chromium.org/2431223004
Cr-Commit-Position: refs/heads/master@{#427840}
Commit  : e1d19b388fc67f31372a4c2df33e20c0c18dfd97
Date    : Wed Oct 26 22:08:28 2016


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N  Good?
chromium@427828  0          N/A      2  good
chromium@427836  0          N/A      2  good
chromium@427838  0          N/A      2  good
chromium@427839  0          N/A      2  good
chromium@427840  1          N/A      2  bad    <--
chromium@427844  1          N/A      2  bad
chromium@427860  1          N/A      2  bad
chromium@427892  1          N/A      2  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 660149

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile
Test Metric: memory:chrome:browser_process:reported_by_os:resident_size_avg/memory:chrome:browser_process:reported_by_os:resident_size_avg
Relative Change: Zero to non-zero
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1767
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997614082469679392


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5900700809166848

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment