Issue 660143 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	s...@chromium.org
Closed:	Oct 2016
Cc:	mastiz@chromium.org █ tschumann@chromium.org
Components:	Services>Sync
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Hotlist-CodeHealth

[Sync] All of the sync code base should use a uniform lint presubmit

Project Member Reported by s...@chromium.org, Oct 27 2016

Issue description

Couple outstanding problems.
1. components/browser_sync, components/sync, components/bookmarks don't have presubmit lints
2. componets/driver/PRESUBMIT.py has an old regex that hits nothing

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a8b6628809e4faeef649143d00651f28de371b4

commit 0a8b6628809e4faeef649143d00651f28de371b4
Author: skym <skym@chromium.org>
Date: Thu Oct 27 23:34:23 2016

[Sync] Updating all sync components to use similar presubmit linting logic.

BUG= 660143 

Review-Url: https://codereview.chromium.org/2455203002
Cr-Commit-Position: refs/heads/master@{#428213}

[add] https://crrev.com/0a8b6628809e4faeef649143d00651f28de371b4/components/browser_sync/PRESUBMIT.py
[modify] https://crrev.com/0a8b6628809e4faeef649143d00651f28de371b4/components/sync/PRESUBMIT.py
[delete] https://crrev.com/d76ba00e6cc2625000d495e79bdc8d747645405e/components/sync/driver/PRESUBMIT.py
[add] https://crrev.com/0a8b6628809e4faeef649143d00651f28de371b4/components/sync_bookmarks/PRESUBMIT.py
[modify] https://crrev.com/0a8b6628809e4faeef649143d00651f28de371b4/components/sync_sessions/PRESUBMIT.py

Comment 2 by s...@chromium.org, Oct 28 2016

Status: Fixed (was: Started)

►

Issue 660143 link

Issue metadata

[Sync] All of the sync code base should use a uniform lint presubmit

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

Comment 1 Deleted

Comment 2 by s...@chromium.org, Oct 28 2016

Comment 2 Deleted

Sign in to add a comment