New issue
Advanced search Search tips

Issue 660141 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Use different error codes in keystone install script

Project Member Reported by garykac@chromium.org, Oct 27 2016

Issue description

The Chromoting Keystone installer scripts always return the same error code ("1") when there is a problem. This results in all of our install errors being combined into a single value in our dashboard.

Instead, we should:
(1) Use different error codes for each error path.
(2) Avoid using an error code of "1" since that is returned by the Keystone updater (vs. our install script). The 2 different "1"s will be plotted separately, but it is confusing to see 2 lines with the same label (since the source of the "1" is not labelled on the graph).

For reference:

Our install script:
https://cs.chromium.org/chromium/src/remoting/host/installer/mac/Scripts/remoting_preflight.sh

Chrome's install script:
https://cs.chromium.org/chromium/src/chrome/installer/mac/keystone_install.sh

 
Status: Assigned (was: Untriaged)
Labels: -M-56 M-57

Comment 3 by joedow@chromium.org, Jan 27 2017

Labels: -M-57

Sign in to add a comment