New issue
Advanced search Search tips

Issue 660138 link

Starred by 2 users
Status: Archived
Owner: ----
Closed: Jan 10
Cc:
piman@chromium.org
tguilbert@chromium.org
zmo@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Convert gpu::Mailbox to use base::UnguessableToken

Project Member Reported by tguilbert@chromium.org, Oct 27 2016 
base::UnguessableToken landed as part of 643857.

gpu::Mailbox is a valid canditate that could be updated to use base::UnguessableToken.

There are a few intermediate steps before the change can be made. piman@ mentions that we are currently 64 bytes as the Mailbox's name, and that there might be a few scripts for which that value is hard coded. piman@ suggest the first step is updating GL_MAILBOX_SIZE_CHROMIUM to 16, and fixing the code, after which it will be easier to transition to UnguessableToken

This bug tracks the work to update gpu::Mailbox to use base::UnguessableToken

Comment 1 by piman@chromium.org, Oct 27 2016

Cc: zmo@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e

commit 02b9c4e04a6c4fbcee7d3a6902145a43110bff1e
Author: piman <piman@chromium.org>
Date: Tue Nov 01 00:25:18 2016

Reduce GPU mailbox size to 16 bytes

16 bytes is enough entropy. This is a precursor to replacing gpu::Mailbox by
base::UnguessableToken (which is 16 bytes).

BUG= 660138 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2461003003
Cr-Commit-Position: refs/heads/master@{#428881}

[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/GLES2/gl2extchromium.h
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/command_buffer/client/gles2_implementation_unittest.cc
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/command_buffer/common/mailbox.h
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/ipc/common/mailbox.mojom
[modify] https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e/gpu/ipc/common/struct_traits_unittest.cc

Comment 4 by benhenry@google.com, Jan 10

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.
►

Sign in to add a comment