New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
Use base::Pickle for storing field trials
Reported by lawrencewu@chromium.org, Oct 27 2016 Back to list
Let's refactor the code around FieldTrialEntry a little bit by using base::Pickle instead of manually calculating offsets.
 
Project Member Comment 1 by bugdroid1@chromium.org, Oct 28 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab1da09492fa8e84ae6d90151bd718efdf97d3f4

commit ab1da09492fa8e84ae6d90151bd718efdf97d3f4
Author: lawrencewu <lawrencewu@chromium.org>
Date: Fri Oct 28 18:05:54 2016

Use pickle for field trial entries in shared memory

This CL changes the data format we use to store field trials in shared
memory from custom offsets to a pickled structure, which has several
advantages. Namely, it handles offsets for us and requires less code.
We will also probably end up using this for experiment parameters as
well.

BUG= 660128 

Review-Url: https://codereview.chromium.org/2449783007
Cr-Commit-Position: refs/heads/master@{#428423}

[modify] https://crrev.com/ab1da09492fa8e84ae6d90151bd718efdf97d3f4/base/metrics/field_trial.cc

Status: Fixed
Sign in to add a comment