Books rendering broken on 55.0.2883.28 with multiprocess enabled |
||||||||
Issue descriptionNote this is not crbug.com/660047 which was another breakage on top, and affects single process as well. Looks like unrelated to crbug.com/651814 as well. Toby's original report: Monochrome version: 55.0.2883.28 Books version: 3.10.27 With multiprocess webview enabled, chrome beta and dev currently render blank pages in books. Works fine in stable, or with multiprocess disabled.
,
Oct 27 2016
probably https://codereview.chromium.org/2377533002 ?
,
Oct 27 2016
yep ok, now that clipping is completely broken in multiprocess :p
,
Oct 27 2016
Issue 651814 has been merged into this issue.
,
Oct 27 2016
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a3725735f8f32c95b672537726037b9d0b9cf10 commit 3a3725735f8f32c95b672537726037b9d0b9cf10 Author: boliu <boliu@chromium.org> Date: Mon Oct 31 13:51:20 2016 sync compositor: Fix multiprocess software clipping Apply the clip before the matrix, so that matrix is not applied to it. Not entirely sure why recent clipping changes did not expose this. BUG= 660119 Review-Url: https://codereview.chromium.org/2462903002 Cr-Commit-Position: refs/heads/master@{#428700} [modify] https://crrev.com/3a3725735f8f32c95b672537726037b9d0b9cf10/content/renderer/android/synchronous_compositor_proxy.cc
,
Oct 31 2016
,
Oct 31 2016
,
Oct 31 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61542163871aece5ede852a931e9197a6cc9b1fc commit 61542163871aece5ede852a931e9197a6cc9b1fc Author: Bo Liu <boliu@chromium.org> Date: Mon Oct 31 20:40:14 2016 [Merge M55] sync compositor: Fix multiprocess software clipping Apply the clip before the matrix, so that matrix is not applied to it. Not entirely sure why recent clipping changes did not expose this. BUG= 660119 Review-Url: https://codereview.chromium.org/2462903002 Cr-Commit-Position: refs/heads/master@{#428700} (cherry picked from commit 3a3725735f8f32c95b672537726037b9d0b9cf10) Review URL: https://codereview.chromium.org/2463713004 . Cr-Commit-Position: refs/branch-heads/2883@{#396} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/61542163871aece5ede852a931e9197a6cc9b1fc/content/renderer/android/synchronous_compositor_proxy.cc
,
Oct 31 2016
,
Nov 2 2016
we are able to repro issue on 55.0.2883.28 , Nexus 6p Pixel XL with multiprocess webview enabled on chrome beta and dev. On latest M55 issue doesn't repro with multiprocess webview enabled on chrome beta and dev. Tested on Nexus 6p Pixel XL. Hence closing this issue. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by boliu@chromium.org
, Oct 27 2016