Rialto: sound_infrastructure test failures |
||||||||||
Issue descriptionFailing in the lab with "Missing device ^controlC(\d+)" E.g. https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=371190914
,
Oct 27 2016
,
Oct 31 2016
,
Nov 8 2016
,
Nov 8 2016
Rialto doesn't do audio at all. That test should be skipped.
,
Nov 8 2016
Right, so I have https://chromium-review.googlesource.com/#/c/406468/ Another way is to remove bvt label from these DUTs - https://screenshot.googleplex.com/T0aq6mPxTLP , but it seems running bvt for rialto is done in purpose. Any other way?
,
Nov 9 2016
is change 406468 sufficient?
,
Nov 9 2016
Yes, it isolates boards like rialto, and either 1) exits the tests by causing PASS or 2) errors out if audio control is observed. The rest of the logic stays same, just modified the way to feed the playback and record devices availability through boards names in list.
,
Nov 9 2016
great. Thanks!
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1525094fe100c40f8497a4e31ae067a2d66ac825 commit 1525094fe100c40f8497a4e31ae067a2d66ac825 Author: Kalin Stoyanov <kalin@chromium.org> Date: Tue Nov 01 23:30:19 2016 Exclude boards with no audio device BUG= chromium:660094 TEST=Ran test for diff boards Change-Id: I25c816c4e3c7e26b8988d919b91429be856c2553 Reviewed-on: https://chromium-review.googlesource.com/406468 Commit-Ready: Kalin Stoyanov <kalin@chromium.org> Tested-by: Kalin Stoyanov <kalin@chromium.org> Reviewed-by: Kalin Stoyanov <kalin@chromium.org> [modify] https://crrev.com/1525094fe100c40f8497a4e31ae067a2d66ac825/client/tests/sound_infrastructure/sound_infrastructure.py
,
Nov 10 2016
,
Nov 10 2016
,
Nov 10 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 10 2016
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6e482629a54ea5e70b44010a21c15cc40cbff1d4 commit 6e482629a54ea5e70b44010a21c15cc40cbff1d4 Author: Kalin Stoyanov <kalin@chromium.org> Date: Tue Nov 01 23:30:19 2016 Exclude boards with no audio device BUG= chromium:660094 TEST=Ran test for diff boards Change-Id: I25c816c4e3c7e26b8988d919b91429be856c2553 Reviewed-on: https://chromium-review.googlesource.com/406468 Commit-Ready: Kalin Stoyanov <kalin@chromium.org> Tested-by: Kalin Stoyanov <kalin@chromium.org> Reviewed-by: Kalin Stoyanov <kalin@chromium.org> (cherry picked from commit 1525094fe100c40f8497a4e31ae067a2d66ac825) Reviewed-on: https://chromium-review.googlesource.com/410142 Commit-Queue: Kalin Stoyanov <kalin@chromium.org> [modify] https://crrev.com/6e482629a54ea5e70b44010a21c15cc40cbff1d4/client/tests/sound_infrastructure/sound_infrastructure.py
,
Nov 10 2016
Should I merge to M-54?
,
Nov 11 2016
Only if you want to. I think we can ignore the M54 failures for the next few weeks.
,
Nov 14 2016
Sounds good, will skip 54. It passes for m55 too. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by joth@chromium.org
, Oct 27 2016