Issue metadata
Sign in to add a comment
|
Do not focus on a root node in a web view with no title |
||||||||||||||||||||||||
Issue descriptionVersion: experimental build OS: Android What steps will reproduce the problem? (1) Open an app that uses a web view, such as Inbox by Gmail. (2) Start TalkBack via Settings > Accessibility -> TalkBack. (3) Open one of the messages and swipe to the body of the message. What is the expected output? TalkBack should read the first element of the message body. What do you see instead? TalkBack focuses on a root node causing the whole message to be read.
,
Nov 16 2016
,
Jun 12 2018
This was accidentally reverted as part of another change. Fixing here: https://chromium-review.googlesource.com/c/chromium/src/+/1097953
,
Jun 12 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a953ec895d88d23a76772b9ff5cce1a4a84348c8 commit a953ec895d88d23a76772b9ff5cce1a4a84348c8 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Jun 13 16:46:35 2018 Android accessibility: skip the root element when it has no title This change was originally landed in r432621 - the idea is that when a page has no title, there's no reason we should allow the user to swipe to the root element. For some reason in r514252 this was inverted as part of making it possible to jump to the last element on a page, but the new logic doesn't make sense. Restore it to the previous behavior. Bug: 661793, 660090 , 801292 Change-Id: Iba81d0429a04845f093c5f07449c26fa8514bda4 Reviewed-on: https://chromium-review.googlesource.com/1097953 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#566868} [modify] https://crrev.com/a953ec895d88d23a76772b9ff5cce1a4a84348c8/content/browser/accessibility/browser_accessibility_android.cc [modify] https://crrev.com/a953ec895d88d23a76772b9ff5cce1a4a84348c8/content/test/data/accessibility/html/isInteresting-expected-android.txt
,
Jun 20 2018
,
Jul 9
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b099b45441859b14ed3b7ca81402af5c28fe2a92 commit b099b45441859b14ed3b7ca81402af5c28fe2a92 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Jul 11 22:17:32 2018 Merge to M68: Android accessibility: skip the root element when it has no title This change was originally landed in r432621 - the idea is that when a page has no title, there's no reason we should allow the user to swipe to the root element. For some reason in r514252 this was inverted as part of making it possible to jump to the last element on a page, but the new logic doesn't make sense. Restore it to the previous behavior. Bug: 661793, 660090 , 801292 Change-Id: Iba81d0429a04845f093c5f07449c26fa8514bda4 Reviewed-on: https://chromium-review.googlesource.com/1097953 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566868}(cherry picked from commit a953ec895d88d23a76772b9ff5cce1a4a84348c8) Reviewed-on: https://chromium-review.googlesource.com/1134101 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#649} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/b099b45441859b14ed3b7ca81402af5c28fe2a92/content/browser/accessibility/browser_accessibility_android.cc [modify] https://crrev.com/b099b45441859b14ed3b7ca81402af5c28fe2a92/content/test/data/accessibility/html/isInteresting-expected-android.txt |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 16 2016