It currently infers the type, which is likely to cause problems with aura.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d435b56642e79cbcc6ace91568a62c692cc9958a commit d435b56642e79cbcc6ace91568a62c692cc9958a Author: sky <sky@chromium.org> Date: Thu Oct 27 22:45:45 2016 Wires up modality for aura-mus BUG= 660073 , 659155 TEST=covered by tests Review-Url: https://codereview.chromium.org/2454973003 Cr-Commit-Position: refs/heads/master@{#428171} [modify] https://crrev.com/d435b56642e79cbcc6ace91568a62c692cc9958a/ui/aura/mus/in_flight_change.cc [modify] https://crrev.com/d435b56642e79cbcc6ace91568a62c692cc9958a/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/d435b56642e79cbcc6ace91568a62c692cc9958a/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/d435b56642e79cbcc6ace91568a62c692cc9958a/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/d435b56642e79cbcc6ace91568a62c692cc9958a/ui/aura/test/mus/test_window_tree.cc [modify] https://crrev.com/d435b56642e79cbcc6ace91568a62c692cc9958a/ui/aura/test/mus/test_window_tree.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46d0c110e7c68b484bfc292cf030d599c9bb8251 commit 46d0c110e7c68b484bfc292cf030d599c9bb8251 Author: moshayedi <moshayedi@chromium.org> Date: Tue Mar 07 13:55:42 2017 Make WindowTree::SetModal() take the type. Previously system modal was implicitly inferred as a modal window who doesn't have a transient parent. But this is not true always, for example a JS alert window can be system modal but also have a transient parent. This CL adds modality type to WindowTree::SetModal() so window server is explicitly told the type of modality a window should take. BUG= 660073 Review-Url: https://codereview.chromium.org/2710023007 Cr-Commit-Position: refs/heads/master@{#455064} [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/public/interfaces/BUILD.gn [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/ws/event_dispatcher_unittest.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/ws/modal_window_controller.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/ws/server_window.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/ws/server_window.h [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/ws/window_tree.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/ws/window_tree.h [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/services/ui/ws/window_tree_unittest.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/mus/in_flight_change.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/mus/in_flight_change.h [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/mus/window_port_mus.h [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/test/mus/test_window_tree.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/test/mus/test_window_tree.h [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/window.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/window_port.h [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/window_port_local.cc [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/aura/window_port_local.h [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/base/mojo/BUILD.gn [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/base/mojo/typemaps.gni [add] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/base/mojo/ui_base_types.mojom [add] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/base/mojo/ui_base_types.typemap [add] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/base/mojo/ui_base_types_struct_traits.h [modify] https://crrev.com/46d0c110e7c68b484bfc292cf030d599c9bb8251/ui/base/mojo/window_open_disposition.typemap
Comment 1 by bugdroid1@chromium.org
, Oct 27 2016