New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660072 link

Starred by 1 user
Status: Fixed
Owner:
█ maxbogue@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[USS] Rename ModelTypeService to ModelTypeSyncBridge

Project Member Reported by maxbogue@chromium.org, Oct 27 2016 
We've decided that ModelTypeService isn't actually a great name because it's not obvious how derived classes should be named. For example, the DeviceInfo implementation is named DeviceInfoService, but this doesn't indicate at all its relationship to sync.

After some discussion, the team things that ModelTypeSyncBridge would be a more descriptive name. The word "bridge" is less overloaded than "service", is more descriptive (it is the bridge between the model type and sync), and lends itself to descriptive names of derived classes: DeviceInfoSyncBridge, etc.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bca8256b27ba1157b3fb6aaf178b56040f82bea2

commit bca8256b27ba1157b3fb6aaf178b56040f82bea2
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Oct 28 20:31:23 2016

[Sync] Rename ModelTypeService to ModelTypeSyncBridge.

BUG= 660072 

Review-Url: https://codereview.chromium.org/2458013002
Cr-Commit-Position: refs/heads/master@{#428477}

[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/chrome/browser/sync/chrome_sync_client.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/BUILD.gn
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/device_info/device_info_service.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/device_info/device_info_service.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/device_info/device_info_service_unittest.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/driver/fake_sync_client.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/driver/fake_sync_client.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/driver/model_type_controller.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/driver/model_type_controller.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/driver/model_type_controller_unittest.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/driver/sync_client.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/driver/sync_driver_switches.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/entity_data.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/fake_model_type_change_processor.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/fake_model_type_change_processor.h
[rename] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/fake_model_type_sync_bridge.cc
[rename] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/fake_model_type_sync_bridge.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/model_type_change_processor.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/model_type_change_processor.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/model_type_debug_info.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/model_type_debug_info.h
[rename] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/model_type_sync_bridge.cc
[rename] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/model_type_sync_bridge.h
[rename] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/model_type_sync_bridge_unittest.cc
[delete] https://crrev.com/b5309bb103c997eb573eac8b1a23d19097f06fe7/components/sync/model/stub_model_type_service.cc
[add] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/stub_model_type_sync_bridge.cc
[rename] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model/stub_model_type_sync_bridge.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model_impl/shared_model_type_processor.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model_impl/shared_model_type_processor.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/components/sync/model_impl/shared_model_type_processor_unittest.cc
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/ios/chrome/browser/sync/ios_chrome_sync_client.h
[modify] https://crrev.com/bca8256b27ba1157b3fb6aaf178b56040f82bea2/ios/chrome/browser/sync/ios_chrome_sync_client.mm

Comment 2 by maxbogue@chromium.org, Oct 28 2016

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6

commit 559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6
Author: skym <skym@chromium.org>
Date: Sun Oct 30 22:38:14 2016

[Sync] Rename DeviceInfoService to DeviceInfoSyncBridge.

BUG= 660072 

Review-Url: https://codereview.chromium.org/2460903003
Cr-Commit-Position: refs/heads/master@{#428633}

[modify] https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6/components/sync/BUILD.gn
[rename] https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6/components/sync/device_info/device_info_sync_bridge.cc
[rename] https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6/components/sync/device_info/device_info_sync_bridge.h
[rename] https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6/components/sync/device_info/device_info_sync_bridge_unittest.cc
[modify] https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6/components/sync/device_info/device_info_util.h
[modify] https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6/ios/chrome/browser/sync/ios_chrome_sync_client.mm
►

Sign in to add a comment