This information will allow MAIN_FRAME URLRequests to be associated with their corresponding NavigationHandles. This is critical to correctly track data used by a page load.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/763c3fe382f8ae7c39cfa28191eab55b1036e4e6 commit 763c3fe382f8ae7c39cfa28191eab55b1036e4e6 Author: kundaji <kundaji@chromium.org> Date: Thu Nov 10 17:45:23 2016 Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. Create DataUseRecorder instances associated with page loads. Instances are associated with either pending navigations or render frame hosts depending on the state of the page load. Use GlobalRequestID to associate MAIN_FRAME URLRequests with their corresponding pending navigation. Complete life-cycle of the DataUseRecorders will be implemented in a forthcoming cl. BUG= 660065 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2413663003 Cr-Commit-Position: refs/heads/master@{#431282} [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/chrome/browser/data_use_measurement/data_use_web_contents_observer.h [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/content/browser/frame_host/navigation_handle_impl.cc [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/content/browser/frame_host/navigation_handle_impl.h [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/content/browser/frame_host/render_frame_host_manager.cc [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/content/browser/loader/resource_request_info_impl.cc [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/content/browser/loader/resource_request_info_impl.h [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/content/public/browser/navigation_handle.h [modify] https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6/content/public/browser/resource_request_info.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/093c9fbda78ab82fd22e1b0c0ae94942eff2660b commit 093c9fbda78ab82fd22e1b0c0ae94942eff2660b Author: dpranke <dpranke@chromium.org> Date: Thu Nov 10 21:50:58 2016 Revert of Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (patchset #14 id:400001 of https://codereview.chromium.org/2413663003/ ) Reason for revert: Looks like this is causing a test to crash on Win7 debug: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54581 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54581/steps/browser_tests%20on%20Windows-7-SP1/logs/PrerenderBrowserTestWithExtensions.StreamsTest So I'm reverting it, after double-checking w/ ryansturm@. Sorry! Original issue's description: > Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. > > Create DataUseRecorder instances associated with page loads. > Instances are associated with either pending navigations or render > frame hosts depending on the state of the page load. Use > GlobalRequestID to associate MAIN_FRAME URLRequests with their > corresponding pending navigation. Complete life-cycle of the > DataUseRecorders will be implemented in a forthcoming cl. > > BUG= 660065 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6 > Cr-Commit-Position: refs/heads/master@{#431282} TBR=clamy@chromium.org,rajendrant@chromium.org,ryansturm@chromium.org,kundaji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 660065 Review-Url: https://codereview.chromium.org/2498433002 Cr-Commit-Position: refs/heads/master@{#431368} [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/chrome/browser/data_use_measurement/data_use_web_contents_observer.h [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/content/browser/frame_host/navigation_handle_impl.cc [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/content/browser/frame_host/navigation_handle_impl.h [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/content/browser/frame_host/render_frame_host_manager.cc [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/content/browser/loader/resource_request_info_impl.cc [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/content/browser/loader/resource_request_info_impl.h [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/content/public/browser/navigation_handle.h [modify] https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b/content/public/browser/resource_request_info.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/187e41f689795ef7ea15dc804ef31289211b12e9 commit 187e41f689795ef7ea15dc804ef31289211b12e9 Author: kundaji <kundaji@chromium.org> Date: Thu Nov 17 00:14:22 2016 Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. Create DataUseRecorder instances associated with page loads. Instances are associated with either pending navigations or render frame hosts depending on the state of the page load. Use GlobalRequestID to associate MAIN_FRAME URLRequests with their corresponding pending navigation. Complete life-cycle of the DataUseRecorders will be implemented in a forthcoming cl. BUG= 660065 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6 Review-Url: https://codereview.chromium.org/2413663003 Cr-Original-Commit-Position: refs/heads/master@{#431282} Cr-Commit-Position: refs/heads/master@{#432672} [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/chrome/browser/data_use_measurement/data_use_web_contents_observer.h [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/components/data_use_measurement/core/data_use_ascriber.cc [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/components/data_use_measurement/core/data_use_ascriber.h [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/components/data_use_measurement/core/data_use_network_delegate.cc [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/components/data_use_measurement/core/data_use_network_delegate.h [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/components/data_use_measurement/core/data_use_recorder.cc [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/components/data_use_measurement/core/data_use_recorder.h [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/content/browser/frame_host/navigation_handle_impl.cc [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/content/browser/frame_host/navigation_handle_impl.h [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/content/browser/frame_host/render_frame_host_manager.cc [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/content/browser/loader/resource_request_info_impl.cc [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/content/browser/loader/resource_request_info_impl.h [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/content/public/browser/navigation_handle.h [modify] https://crrev.com/187e41f689795ef7ea15dc804ef31289211b12e9/content/public/browser/resource_request_info.h
Comment 1 by kundaji@chromium.org
, Oct 27 2016