Deduplicate WebKitFinder.layout_test_name and Port.relative_test_filename. |
||
Issue descriptionAfter I added WebKitFinder.layout_test_name, there are now two ways to get the layout test name based on a file path, which are slightly different. One of these should be removed, and there should be a test that ensures that it works with Windows file paths; see bug 658795 .
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db56053f8acad0efe2406cca5ff984a425d7392e commit db56053f8acad0efe2406cca5ff984a425d7392e Author: Quinten Yearsley <qyearsley@google.com> Date: Wed Aug 16 00:32:55 2017 Remove PathFinder.layout_test_name Reason: There is already a function with basically the same purpose (Port.relative_test_name). In the two places where PathFinder.layout_test_name was used, there was no port object but I still think that removing this method is an overall improvement. Bug: 660064 Change-Id: I19d3af7ffece559a2a4bf3f43c7441c6670603b3 Reviewed-on: https://chromium-review.googlesource.com/614606 Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#494631} [modify] https://crrev.com/db56053f8acad0efe2406cca5ff984a425d7392e/third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder.py [modify] https://crrev.com/db56053f8acad0efe2406cca5ff984a425d7392e/third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder_unittest.py [modify] https://crrev.com/db56053f8acad0efe2406cca5ff984a425d7392e/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py [modify] https://crrev.com/db56053f8acad0efe2406cca5ff984a425d7392e/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py [modify] https://crrev.com/db56053f8acad0efe2406cca5ff984a425d7392e/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
,
Aug 16 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Dec 28 2016