New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660061 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 475027



Sign in to add a comment

PlzNavigate: Going back to page with iframe srcdoc fails to load iframe

Project Member Reported by creis@chromium.org, Oct 27 2016

Issue description

Version: 56.0.2902.0
OS: All

What steps will reproduce the problem?
(1) Start Chrome with --enable-browser-side-navigation.
(2) Visit http://csreis.github.io/tests/iframe-srcdoc.html
(3) Visit http://csreis.github.io/tests/
(4) Go back.

What is the expected output?
The iframe should load (i.e., show form inputs).

What do you see instead?
The iframe stays blank.

I noticed this while adding a case to the RestoreSubframeFileAccessForHistoryNavigation test in RenderFrameHostManagerTest.  That test has always exercised the bug, but there was never a check that noticed the iframe was blank when we came back.  I'm disabling the test there now that it fails in PlzNavigate.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/041956a261766b15f09b7b7a37026bda1ef809f3

commit 041956a261766b15f09b7b7a37026bda1ef809f3
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Wed Nov 30 14:35:27 2016

Remove about:srcdoc url conversion.

Before this CL, there was an asymmetry between the renderer and the
browser. Iframe that has navigated to its srcdoc attribute got the
about:srcdoc URL in the renderer and the about:blank in the browser.
The about::srcdoc URLs were converted to about::blank in the RendererFrameHost.
A boolean |is_srcdoc| was created and transmitted across classes in
the browser to keep track of the "real" URL, such as it could be
converted back (browser->renderer).

This led to a lot unnecessary works to keep track of this boolean and
not to forget to convert the URL back.

This CL removes the conversion and the boolean from the browser.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

BUG= 660061 

Review-Url: https://codereview.chromium.org/2494633004
Cr-Commit-Position: refs/heads/master@{#435256}

[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/history/history_utils.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/prerender/prerender_contents.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/prerender/prerender_tab_helper.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/prerender/prerender_tab_helper.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/tracing/navigation_tracing.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/tracing/navigation_tracing.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/ui/search/search_tab_helper_unittest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/ui/webui/options/options_ui.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/browser/ui/webui/settings/md_settings_ui.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/chrome/test/data/extensions/api_test/executescript/frame_id/test.js
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/components/dom_distiller/content/browser/distillability_driver.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/components/dom_distiller/content/browser/distillability_driver.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/android/web_contents_observer_proxy.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/android/web_contents_observer_proxy.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/child_process_security_policy_unittest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/frame_tree_browsertest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/interstitial_page_navigator_impl.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/navigator_delegate.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/common/frame_messages.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/public/browser/navigation_handle.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/public/browser/navigation_handle.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/public/test/test_frame_navigation_observer.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/public/test/test_frame_navigation_observer.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/public/test/test_navigation_observer.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/public/test/test_navigation_observer.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/test/web_contents_observer_sanity_checker.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/content/test/web_contents_observer_sanity_checker.h
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc
[modify] https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3/testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter

Comment 2 by battre@chromium.org, Nov 30 2016

I expect this to have caused the following error on multiple bots. Reverting.

/b/rr/tmpweY7dF/w/layout-test-results/fast/history/history-length-append-subframe-with-hash-actual.txt
1010
1111============== Back Forward List ==============
1212curr->  (file test):fast/history/history-length-append-subframe-with-hash.html#wentBack
13             about:blank/#identifier (in frame "<!--framePath //<!--frame0-->-->")
 13            about:blank (in frame "<!--framePath //<!--frame0-->-->")
1414        data:text/html,<body onload="history.back()">Must not see this text!!!</body>
1515===============================================
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00

commit ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Tue Dec 06 10:52:29 2016

Remove about:srcdoc url conversion.

This is a reland of https://codereview.chromium.org/2494633004/

Before this CL, there was an asymetry between the renderer and the
browser. Iframe that has navigated to its srcdoc attribute got the
about:srcdoc URL in the renderer and the about::blank in the browser.
The about::srcdoc url were converted to about::blank in the RendererFrameHost.
A boolean |is_srcdoc| was created and transmitted across classes in
the browser to keep track of the "real" url, such as it could be
converted back (browser->renderer).

This led to a lot unnecessary works to keep track of this boolean and
not to forget to convert the URL back.

This CL removes the conversion and the boolean from the browser.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

BUG= 660061 
TBR=dbeam,nasko

Review-Url: https://codereview.chromium.org/2534393003
Cr-Commit-Position: refs/heads/master@{#436567}

[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/history/history_utils.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/prerender/prerender_contents.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/prerender/prerender_tab_helper.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/prerender/prerender_tab_helper.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/tracing/navigation_tracing.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/tracing/navigation_tracing.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/ui/search/search_tab_helper_unittest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/ui/webui/options/options_ui.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/browser/ui/webui/settings/md_settings_ui.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/chrome/test/data/extensions/api_test/executescript/frame_id/test.js
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/components/dom_distiller/content/browser/distillability_driver.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/components/dom_distiller/content/browser/distillability_driver.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/android/web_contents_observer_proxy.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/android/web_contents_observer_proxy.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/child_process_security_policy_unittest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/frame_tree_browsertest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/interstitial_page_navigator_impl.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/navigator_delegate.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/common/frame_messages.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/public/browser/navigation_handle.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/public/browser/navigation_handle.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/public/test/test_frame_navigation_observer.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/public/test/test_frame_navigation_observer.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/public/test/test_navigation_observer.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/public/test/test_navigation_observer.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/test/web_contents_observer_sanity_checker.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/content/test/web_contents_observer_sanity_checker.h
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc
[modify] https://crrev.com/ee7f43bbfe2425d9a34c4fe29bdec6609c6d8d00/testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter

Comment 4 by clamy@chromium.org, Apr 20 2017

Status: Fixed (was: Untriaged)

Comment 5 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 6 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment