New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 660038 link

Starred by 1 user
Status: Fixed
Owner:
█ lawrencewu@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
asvitk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move VariationsParamAssociator to base

Reported by lawrencewu@chromium.org, Oct 27 2016 
In order to eventually enable experiment parameters in child processes, we must first move the VariationsParamAssociator, where variation parameters are currently stored, from components/ to base/.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d5ac0c30be692e2e918121e140a869af36f8dc2

commit 5d5ac0c30be692e2e918121e140a869af36f8dc2
Author: lawrencewu <lawrencewu@chromium.org>
Date: Mon Oct 31 14:52:16 2016

Move VariationsParamAssociator to base

Moves VariationsParamAssociator to base as FieldTrialParamAssociator
and just reroutes the calls in variations_associated_data.cc to this
new class in field_trial_param_associator.h/.cc. This is so we can eventually get field trial parameters into child processes using shared memory.

BUG= 660038 

Review-Url: https://codereview.chromium.org/2456723004
Cr-Commit-Position: refs/heads/master@{#428710}

[modify] https://crrev.com/5d5ac0c30be692e2e918121e140a869af36f8dc2/base/BUILD.gn
[add] https://crrev.com/5d5ac0c30be692e2e918121e140a869af36f8dc2/base/metrics/field_trial_param_associator.cc
[add] https://crrev.com/5d5ac0c30be692e2e918121e140a869af36f8dc2/base/metrics/field_trial_param_associator.h
[modify] https://crrev.com/5d5ac0c30be692e2e918121e140a869af36f8dc2/components/variations/variations_associated_data.cc

Comment 2 by lawrencewu@chromium.org, Oct 31 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment