Credential Manager account picker swaps profile images |
|||||
Issue descriptionVersion: Canary 56.0.2901.3 OS: Android 7.0.0; Nexus6 Build/NBD91L What steps will reproduce the problem? (1) go to https://polykart-credential-payment.appspot.com (2) create one id/password account (3) create one Google Sign-In account with a profile image (4) Sign out and tap on sign-in icon on top right What is the expected output? Account chooser showing one with "with accounts.google.com" with an profile image, the id/password one with default profile image What do you see instead? Account chooser profile image is shown in the id/password one and "with accounts.google.com" one shows default image Please use labels and text to provide additional information.
,
Oct 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a46b550f643ef7199915d087f9861406763d3e9 commit 1a46b550f643ef7199915d087f9861406763d3e9 Author: melandory <melandory@chromium.org> Date: Sat Oct 29 08:07:05 2016 [Smart Lock] Account chooser assign correct avatar to profile. Fixes the bug, where avatar doesn't correspond to correct account in the Account Chooser Dialog on Android. BUG= 660029 Review-Url: https://codereview.chromium.org/2454993004 Cr-Commit-Position: refs/heads/master@{#428609} [modify] https://crrev.com/1a46b550f643ef7199915d087f9861406763d3e9/chrome/browser/password_manager/account_chooser_dialog_android.cc
,
Nov 3 2016
I want to merge r428609 back to 55. The fix is important and safe.
,
Nov 3 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/243f1e1042bcc0728002a7702ae4fc6a42338d25 commit 243f1e1042bcc0728002a7702ae4fc6a42338d25 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Nov 03 17:58:31 2016 [Smart Lock] Account chooser assign correct avatar to profile. Fixes the bug, where avatar doesn't correspond to correct account in the Account Chooser Dialog on Android. BUG= 660029 Review-Url: https://codereview.chromium.org/2454993004 Cr-Commit-Position: refs/heads/master@{#428609} (cherry picked from commit 1a46b550f643ef7199915d087f9861406763d3e9) Review URL: https://codereview.chromium.org/2476633004 . Cr-Commit-Position: refs/branch-heads/2883@{#439} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/243f1e1042bcc0728002a7702ae4fc6a42338d25/chrome/browser/password_manager/account_chooser_dialog_android.cc
,
Jun 19 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vasi...@chromium.org
, Oct 27 2016Owner: melandory@chromium.org
Status: Assigned (was: Untriaged)